From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 0D0985963 for ; Sun, 4 Jan 2015 09:30:30 +0100 (CET) Received: by mail-wg0-f48.google.com with SMTP id l2so664057wgh.35 for ; Sun, 04 Jan 2015 00:30:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Qu10+N4vxhDjBHX39ki662BPpTl/XxX8yxQTHhHIrXo=; b=eB+I1zD8OY/RLmQoXoPjx0cFO7HrLmSl1kmux2NtcePmhIFZwM8K2uirNydVr6KhhP +eTFYAp7AN98/Lg9lvYu9QuXSvBUgou+9rYQhEY2PU//Jnd8XitsDgCEyphsrfPXHtpk sR38BKtQxgR+AZ4qaNwkPA4LfdUndj6t/ue1wTF1JSvIKxqnAYtj/VGfoGbK2oDEdud/ YVVTK727wLFISBQb7YawPDFyyL4k5DUpZOdbapZUieHEnNoo1yQQiYUWkYkl5VbD0jtE vCcBqUVkP5bBspOg0AnOeCdHlhaP2T4wYyqLEyw/tirofddJtWuA4Kl56qIAKrbV7/81 T2+w== X-Gm-Message-State: ALoCoQmbNtbskEpAiMQ/KLrwd9fcQw/gGmZymf4Gu3NlJ4yK9pMYQAPHFBgbl6uq9eISb93/tAQ5 X-Received: by 10.180.73.235 with SMTP id o11mr13763143wiv.51.1420360229842; Sun, 04 Jan 2015 00:30:29 -0800 (PST) Received: from [10.0.0.3] (bzq-79-179-0-199.red.bezeqint.net. [79.179.0.199]) by mx.google.com with ESMTPSA id ej10sm7862539wib.1.2015.01.04.00.30.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2015 00:30:29 -0800 (PST) Message-ID: <54A8FA23.1090802@cloudius-systems.com> Date: Sun, 04 Jan 2015 10:30:27 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ouyang Changchun , dev@dpdk.org References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-3-git-send-email-changchun.ouyang@intel.com> <54A8F93F.4080402@cloudius-systems.com> In-Reply-To: <54A8F93F.4080402@cloudius-systems.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/6] ixgbe: Negotiate VF API version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jan 2015 08:30:30 -0000 On 01/04/15 10:26, Vlad Zolotarov wrote: > > On 01/04/15 09:18, Ouyang Changchun wrote: >> Negotiate API version with VF when receiving the >> IXGBE_VF_API_NEGOTIATE message. >> >> Signed-off-by: Changchun Ouyang > > Reviewed-by: Vlad Zolotarov One small remark below. > >> --- >> lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 + >> lib/librte_pmd_ixgbe/ixgbe_pf.c | 25 +++++++++++++++++++++++++ >> 2 files changed, 26 insertions(+) >> >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >> b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >> index ca99170..730098d 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >> +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.h >> @@ -159,6 +159,7 @@ struct ixgbe_vf_info { >> uint16_t tx_rate[IXGBE_MAX_QUEUE_NUM_PER_VF]; >> uint16_t vlan_count; >> uint8_t spoofchk_enabled; >> + uint8_t api_version; >> }; >> /* >> diff --git a/lib/librte_pmd_ixgbe/ixgbe_pf.c >> b/lib/librte_pmd_ixgbe/ixgbe_pf.c >> index 51da1fd..495aff5 100644 >> --- a/lib/librte_pmd_ixgbe/ixgbe_pf.c >> +++ b/lib/librte_pmd_ixgbe/ixgbe_pf.c >> @@ -469,6 +469,28 @@ ixgbe_set_vf_lpe(struct rte_eth_dev *dev, >> __rte_unused uint32_t vf, uint32_t *ms >> } >> static int >> +ixgbe_negotiate_vf_api(struct rte_eth_dev *dev, uint32_t vf, >> uint32_t *msgbuf) >> +{ >> + uint32_t api_version = msgbuf[1]; >> + struct ixgbe_vf_info *vfinfo = >> + *IXGBE_DEV_PRIVATE_TO_P_VFDATA(dev->data->dev_private); >> + >> + switch (api_version) { >> + case ixgbe_mbox_api_10: >> + case ixgbe_mbox_api_11: Why version 2.0 is not negotiated? >> + vfinfo[vf].api_version = (uint8_t)api_version; >> + return 0; >> + default: >> + break; >> + } >> + >> + RTE_LOG(ERR, PMD, "Negotiate invalid api version %u from VF %d\n", >> + api_version, vf); >> + >> + return -1; >> +} >> + >> +static int >> ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t vf) >> { >> uint16_t mbx_size = IXGBE_VFMAILBOX_SIZE; >> @@ -512,6 +534,9 @@ ixgbe_rcv_msg_from_vf(struct rte_eth_dev *dev, >> uint16_t vf) >> case IXGBE_VF_SET_VLAN: >> retval = ixgbe_vf_set_vlan(dev, vf, msgbuf); >> break; >> + case IXGBE_VF_API_NEGOTIATE: >> + retval = ixgbe_negotiate_vf_api(dev, vf, msgbuf); >> + break; >> default: >> PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", >> (unsigned)msgbuf[0]); >> retval = IXGBE_ERR_MBX; >