From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 1FE9B5A34 for ; Sun, 4 Jan 2015 10:46:49 +0100 (CET) Received: by mail-we0-f169.google.com with SMTP id m14so6401783wev.28 for ; Sun, 04 Jan 2015 01:46:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Ku5PvDV16eM5YHOV3JIrNd6ut8OQy1k3HcwbuOjrU/w=; b=K+MDDOdoPMrOLEcggVjNlJw1kFSOHXxXy0BVlwUaIdqt+nNBg49ghty/NtUoX1VfDX DY7m7e4//rgLZvJB84txbBqBP6Gx4QFTXgYdATUyDXRC2Que4uL46pI+uVzmsLJzozak mHzJZeHkUMU/R8ZTzpSK1PnfFUe4tWk1Ji64W2chmWWG5hLm1p/QLRGJ+c7Uui8n2O84 lSWnCsqP8henTuh3NnXm/jtthaLyyg0AkIZXFSLxIYSPQy83Iioq28coHEHysyEzb8N1 5AquSAZwEpjswon0kBSDU6VZ7ZdweRdQUJR6VLURW1r1N7hikVV6oMm0E3LHViGqUHBp MXcw== X-Gm-Message-State: ALoCoQlnYrribxHX+N6oQ7fxSVHR6WWM4yA5Xos2DccSJ9fd136bNSlTxBQwSaQKGaKz9xZvP1pn X-Received: by 10.194.239.233 with SMTP id vv9mr2108716wjc.90.1420364809025; Sun, 04 Jan 2015 01:46:49 -0800 (PST) Received: from [10.0.0.3] (bzq-79-179-0-199.red.bezeqint.net. [79.179.0.199]) by mx.google.com with ESMTPSA id dc1sm5416429wib.18.2015.01.04.01.46.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Jan 2015 01:46:48 -0800 (PST) Message-ID: <54A90C07.5090507@cloudius-systems.com> Date: Sun, 04 Jan 2015 11:46:47 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Ouyang, Changchun" , "dev@dpdk.org" References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-7-git-send-email-changchun.ouyang@intel.com> <54A8FE9A.60606@cloudius-systems.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jan 2015 09:46:49 -0000 On 01/04/15 11:01, Ouyang, Changchun wrote: >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Sunday, January 4, 2015 4:50 PM >> To: Ouyang, Changchun; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >> >> >> On 01/04/15 09:18, Ouyang Changchun wrote: >>> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS >> information. >>> Signed-off-by: Changchun Ouyang >>> --- >>> app/test-pmd/testpmd.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>> 8c69756..6230f8b 100644 >>> --- a/app/test-pmd/testpmd.c >>> +++ b/app/test-pmd/testpmd.c >>> @@ -1708,6 +1708,16 @@ init_port_config(void) >>> port->dev_conf.rxmode.mq_mode = >> ETH_MQ_RX_NONE; >>> } >>> >>> + if (port->dev_info.max_vfs != 0) { >>> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) >>> + port->dev_conf.rxmode.mq_mode = >>> + ETH_MQ_RX_VMDQ_RSS; >>> + else { >>> + port->dev_conf.rxmode.mq_mode = >> ETH_MQ_RX_NONE; >>> + port->dev_conf.txmode.mq_mode = >> ETH_MQ_TX_NONE; >> >> And what about the txmode.mq_mode when RSS is available (the :if" clause)? > I think we can keep its original value for txmode.mq_mode, so don't change its value. How do you think of it? I agree that not changing a Tx mq_mode in both cases would be better. > Thanks > Changchun > >