From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id 94F525A5F for ; Mon, 5 Jan 2015 11:12:31 +0100 (CET) Received: by mail-we0-f174.google.com with SMTP id k48so7543510wev.5 for ; Mon, 05 Jan 2015 02:12:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FB2IKSBU9E4MF0OCe4YIgfPXKRT2fohF8hK4riOlxNg=; b=WrQ9il/aLDasRqxpIM2Fi995kFS5Uksgva02i70RRzZCKpSrKfkso5xbVFjVg0Yisg b+TtBklZnEgG/MthwjQvHPdY61oncHaxWluYEu5BCZFkg1bdA85x/fwp/VwCk4/t/41l a/tp2GuFuoLXs5I3uDrwz1Fxmx7VF9PBpFhUPM0YX9s6Jl5ewhoNRlgxv+V1jceQXUmG bOMEJ3JVj5XGkUYrWE43+hqJf8gl57h6NTXa7xNnlkF7K8xy+SVUfRIiJFqzaBJ21gYM cJRI6RFDXrBHDOwQ3L5JIOldphxcfvvTYCmkjzeumfs5AtQ2OJ50LWc6QTB+RUUKO6z1 bxjg== X-Gm-Message-State: ALoCoQm7gL3j6is6MQZyQLzNNXo9zxScCZnXUsdm5UOcNAwRtzEwt7pysdBiKYWN71G1iovRzsO8 X-Received: by 10.194.200.234 with SMTP id jv10mr179398169wjc.110.1420452751478; Mon, 05 Jan 2015 02:12:31 -0800 (PST) Received: from [10.0.0.165] (system.cloudius-systems.com. [84.94.198.183]) by mx.google.com with ESMTPSA id lg7sm9318413wic.0.2015.01.05.02.12.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 02:12:30 -0800 (PST) Message-ID: <54AA6385.7020009@cloudius-systems.com> Date: Mon, 05 Jan 2015 12:12:21 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Ouyang, Changchun" , "dev@dpdk.org" References: <1419398584-19520-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420355937-18484-7-git-send-email-changchun.ouyang@intel.com> <54A8FE9A.60606@cloudius-systems.com> <54A90C07.5090507@cloudius-systems.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 10:12:31 -0000 On 01/05/15 04:38, Ouyang, Changchun wrote: > >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Sunday, January 4, 2015 5:47 PM >> To: Ouyang, Changchun; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >> >> >> On 01/04/15 11:01, Ouyang, Changchun wrote: >>>> -----Original Message----- >>>> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >>>> Sent: Sunday, January 4, 2015 4:50 PM >>>> To: Ouyang, Changchun; dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH v4 6/6] testpmd: Set Rx VMDq RSS mode >>>> >>>> >>>> On 01/04/15 09:18, Ouyang Changchun wrote: >>>>> Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS >>>> information. >>>>> Signed-off-by: Changchun Ouyang >>>>> --- >>>>> app/test-pmd/testpmd.c | 10 ++++++++++ >>>>> 1 file changed, 10 insertions(+) >>>>> >>>>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index >>>>> 8c69756..6230f8b 100644 >>>>> --- a/app/test-pmd/testpmd.c >>>>> +++ b/app/test-pmd/testpmd.c >>>>> @@ -1708,6 +1708,16 @@ init_port_config(void) >>>>> port->dev_conf.rxmode.mq_mode = >>>> ETH_MQ_RX_NONE; >>>>> } >>>>> >>>>> + if (port->dev_info.max_vfs != 0) { >>>>> + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) >>>>> + port->dev_conf.rxmode.mq_mode = >>>>> + ETH_MQ_RX_VMDQ_RSS; >>>>> + else { >>>>> + port->dev_conf.rxmode.mq_mode = >>>> ETH_MQ_RX_NONE; >>>>> + port->dev_conf.txmode.mq_mode = >>>> ETH_MQ_TX_NONE; >>>> >>>> And what about the txmode.mq_mode when RSS is available (the :if" >> clause)? >>> I think we can keep its original value for txmode.mq_mode, so don't >> change its value. How do you think of it? >> >> I agree that not changing a Tx mq_mode in both cases would be better. > In the else clause, set txmode.mq_mode as ETH_MQ_TX_NONE explicitly to make sure it is neither ETH_MQ_TX_DCB, > ETH_MQ_TX_VMDQ_DCB, nor ETH_MQ_TX_VMDQ_ONLY. It's not obvious to me why u should do that since AFAIK any of these modes requires RX_RSS. Do I miss anything? > >>> Thanks >>> Changchun >>> >>>