From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id CCF2B12A8 for ; Thu, 8 Jan 2015 10:56:48 +0100 (CET) Received: by mail-wi0-f177.google.com with SMTP id l15so2138695wiw.4 for ; Thu, 08 Jan 2015 01:56:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=7Z/7zh3kcXpkHp+IBl6wUool2jS2FWv6VxG9oatp6QA=; b=ZNIbaEuowpWYrIbTfycNjFvApr/PczWI80XnY9Q4cPCmzWc3SR4xEtM3WViUmYcOeB 9a8jrZ/ufkVZd7VpiyWw2ZUEvYRUxYEwVMGVbFrNiR3DVDibLBgNyiq5TwFDNcjIMVMc aJRCCycI1qe4HQz0hkDmY9Fz2CkKgShPzuNDpjCrQ+tetwlPr2NbY+oM8nsJH8bRNdru Ezl0Km4vrExNntfZZUKQON4reD+iGD939ZThn2UejRUzpjWdkZBIr+OO44EJcXIpJMMf ggzAx2CL9Z17ODoxvWlozEFUYCyhvFQArjfy0P+cCDHgb5vpuaWmeuqABhWzI21gqiZP 1L+w== X-Gm-Message-State: ALoCoQnotYok62gJ3r07y0gPOjwyU4oSuKmXvG3PQkt282QH6n+9HTiUDGxqvchXmu9w4U8KfH99 X-Received: by 10.194.76.73 with SMTP id i9mr17242899wjw.93.1420711008573; Thu, 08 Jan 2015 01:56:48 -0800 (PST) Received: from [10.0.0.4] ([109.66.137.113]) by mx.google.com with ESMTPSA id eu15sm5863042wid.18.2015.01.08.01.56.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jan 2015 01:56:48 -0800 (PST) Message-ID: <54AE545F.4080704@cloudius-systems.com> Date: Thu, 08 Jan 2015 11:56:47 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ouyang Changchun , dev@dpdk.org References: <1420355937-18484-1-git-send-email-changchun.ouyang@intel.com> <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> In-Reply-To: <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2015 09:56:48 -0000 On 01/07/15 08:32, Ouyang Changchun wrote: > This patch enables VF RSS for Niantic, which allow each VF having at most 4 queues. > The actual queue number per VF depends on the total number of pool, which is > determined by the max number of VF at PF initialization stage and the number of > queue specified in config: > 1) If the max number of VF is in the range from 1 to 32, and the number of rxq is 4 > ('--rxq 4' in testpmd), then there is totally 32 pools(ETH_32_POOLS), and each VF > have 4 queues; > > 2)If the max number of VF is in the range from 33 to 64, and the number of rxq is 2 > ('--rxq 2' in testpmd), then there is totally 64 pools(ETH_64_POOLS), and each VF > have 2 queues; > > On host, to enable VF RSS functionality, rx mq mode should be set as ETH_MQ_RX_VMDQ_RSS > or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated(max_vfs >= 1). > It also needs config VF RSS information like hash function, RSS key, RSS key length. > > The limitation for Niantic VF RSS is: > the hash and key are shared among PF and all VF, the RETA table with 128 entries are > also shared among PF and all VF. So it could not to provide a method to query the hash > and reta content per VF on guest, while, if possible, please query them on host(PF) for > the shared RETA information. I've acked PATCH1 and PATCH2 already before and since there are no changes in them, pls., consider them ACKed... ;) > > changes in v5: > - Fix minor issue and some comments; > > changes in v4: > - Extract a function to remove embeded switch-case statement; > - Check whether RX queue number is a valid one, otherwise return error; > - Update the description a bit; > > changes in v3: > - More cleanup; > > changes in v2: > - Update the description; > - Use receiving queue number('--rxq ') specified in config to determine the > number of pool and the number of queue per VF; > > changes in v1: > - Config VF RSS; > > Changchun Ouyang (6): > ixgbe: Code cleanup > ixgbe: Negotiate VF API version > ixgbe: Get VF queue number > ether: Check VMDq RSS mode > ixgbe: Config VF RSS > testpmd: Set Rx VMDq RSS mode > > app/test-pmd/testpmd.c | 15 +++- > lib/librte_ether/rte_ethdev.c | 50 +++++++++++-- > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 + > lib/librte_pmd_ixgbe/ixgbe_pf.c | 80 ++++++++++++++++++++- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 138 ++++++++++++++++++++++++++++-------- > 5 files changed, 248 insertions(+), 36 deletions(-) >