From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f175.google.com (mail-we0-f175.google.com [74.125.82.175]) by dpdk.org (Postfix) with ESMTP id B69585AA8 for ; Mon, 12 Jan 2015 15:05:37 +0100 (CET) Received: by mail-we0-f175.google.com with SMTP id k11so19202997wes.6 for ; Mon, 12 Jan 2015 06:05:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=wY94dlCgQYThXyaNDHLnRdXwbj0OOxJ8ddeKIQKfyN4=; b=FM7DJuzIG3IV2/pKnzekmhH8J9CxzhG184SvkikU7HJ7V0S2tPmGJiNtalyBg4UO6D xhLiPrXbzEeIC8quPc9wQEl9R5S1qYBFnRf5G1EIrymVLXFiM2pfmbRUSQdBZAkzeKdk IA9XQZD4lD2zXa4HiYTABafODdccutKHyKROEE/b9d74EaqLY+lQS1m5m5ekmCasypsd ugctOPg7DY7sMOZsxNqXY5vwe8s4hteqgG1cdM9QofIrXFx0c9cThzoQ/TKrQlDr978D 8I4PsdUKji36PsVMdn0CFjB5mf+UaWeyFKtLEpFFaLi1wZvpn/Kpkw/Ww3S3QaL87VrQ jMyQ== X-Gm-Message-State: ALoCoQkRhDFzklRku5FT36+3A2cGpcwyVo1XGUn+CbSLfGOt9nPQ8zsb564Rq0b+UPLNR+z/a1Xp X-Received: by 10.194.62.19 with SMTP id u19mr60674423wjr.0.1421071537543; Mon, 12 Jan 2015 06:05:37 -0800 (PST) Received: from [10.0.0.165] (system.cloudius-systems.com. [84.94.198.183]) by mx.google.com with ESMTPSA id u18sm21742666wjq.42.2015.01.12.06.05.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jan 2015 06:05:37 -0800 (PST) Message-ID: <54B3D4A7.2050504@cloudius-systems.com> Date: Mon, 12 Jan 2015 16:05:27 +0200 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Ouyang Changchun , dev@dpdk.org References: <1420612355-6666-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-1-git-send-email-changchun.ouyang@intel.com> <1421042352-22399-7-git-send-email-changchun.ouyang@intel.com> In-Reply-To: <1421042352-22399-7-git-send-email-changchun.ouyang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 6/6] testpmd: Set Rx VMDq RSS mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2015 14:05:38 -0000 On 01/12/15 07:59, Ouyang Changchun wrote: > Set VMDq RSS mode if it has VF(VF number is more than 1) and has RSS information. > > Signed-off-by: Changchun Ouyang Reviewed-by: Vlad Zolotarov > > changes in v6 > - Put common statement outside the if branch. > > changes in v5 > - Assign txmode.mq_mode with ETH_MQ_TX_NONE explicitly; > - Remove one line wrong comment. > > --- > app/test-pmd/testpmd.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 8c69756..773b8af 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1700,7 +1700,6 @@ init_port_config(void) > port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0; > } > > - /* In SR-IOV mode, RSS mode is not available */ > if (port->dcb_flag == 0 && port->dev_info.max_vfs == 0) { > if( port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) > port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS; > @@ -1708,6 +1707,17 @@ init_port_config(void) > port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; > } > > + if (port->dev_info.max_vfs != 0) { > + if (port->dev_conf.rx_adv_conf.rss_conf.rss_hf != 0) > + port->dev_conf.rxmode.mq_mode = > + ETH_MQ_RX_VMDQ_RSS; > + else > + port->dev_conf.rxmode.mq_mode = > + ETH_MQ_RX_NONE; > + > + port->dev_conf.txmode.mq_mode = ETH_MQ_TX_NONE; > + } > + > port->rx_conf.rx_thresh = rx_thresh; > port->rx_conf.rx_free_thresh = rx_free_thresh; > port->rx_conf.rx_drop_en = rx_drop_en;