From: Olivier MATZ <olivier.matz@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd:csum fwd engine change
Date: Fri, 16 Jan 2015 18:29:49 +0100 [thread overview]
Message-ID: <54B94A8D.5090905@6wind.com> (raw)
In-Reply-To: <1421375468-18083-3-git-send-email-jijiang.liu@intel.com>
Hi Jijiang,
On 01/16/2015 03:31 AM, Jijiang Liu wrote:
> change the palce of setting UDP tunneling packet offload flag.
typo here
>
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
> app/test-pmd/csumonly.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index 41711fd..57afdfc 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -256,9 +256,6 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
> struct udp_hdr *udp_hdr;
> uint64_t ol_flags = 0;
>
> - if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
> - ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
> -
> if (outer_ethertype == _htons(ETHER_TYPE_IPv4)) {
> ipv4_hdr->hdr_checksum = 0;
>
> @@ -392,6 +389,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
> tunnel = 1;
>
> if (tunnel == 1) {
> + if (testpmd_ol_flags &
> + TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)
> + ol_flags |= PKT_TX_UDP_TUNNEL_PKT;
> +
> outer_ethertype = ethertype;
> outer_l2_len = l2_len;
> outer_l3_len = l3_len;
>
Can you explain why you are moving this code?
Regards,
Olivier
next prev parent reply other threads:[~2015-01-16 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 2:31 [dpdk-dev] [PATCH 0/2] support TSO on i40e Jijiang Liu
2015-01-16 2:31 ` [dpdk-dev] [PATCH 1/2] i40e:support i40e TSO Jijiang Liu
2015-01-16 17:41 ` Olivier MATZ
2015-01-16 2:31 ` [dpdk-dev] [PATCH 2/2] app/testpmd:csum fwd engine change Jijiang Liu
2015-01-16 17:29 ` Olivier MATZ [this message]
2015-01-16 16:44 ` [dpdk-dev] [PATCH 0/2] support TSO on i40e Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B94A8D.5090905@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).