From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 7E2175A8B for ; Fri, 16 Jan 2015 18:29:58 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YCAm3-0002kO-6i; Fri, 16 Jan 2015 18:33:34 +0100 Message-ID: <54B94A8D.5090905@6wind.com> Date: Fri, 16 Jan 2015 18:29:49 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Jijiang Liu , dev@dpdk.org References: <1421375468-18083-1-git-send-email-jijiang.liu@intel.com> <1421375468-18083-3-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1421375468-18083-3-git-send-email-jijiang.liu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd:csum fwd engine change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2015 17:29:58 -0000 Hi Jijiang, On 01/16/2015 03:31 AM, Jijiang Liu wrote: > change the palce of setting UDP tunneling packet offload flag. typo here > > Signed-off-by: Jijiang Liu > --- > app/test-pmd/csumonly.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 41711fd..57afdfc 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -256,9 +256,6 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype, > struct udp_hdr *udp_hdr; > uint64_t ol_flags = 0; > > - if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > - ol_flags |= PKT_TX_UDP_TUNNEL_PKT; > - > if (outer_ethertype == _htons(ETHER_TYPE_IPv4)) { > ipv4_hdr->hdr_checksum = 0; > > @@ -392,6 +389,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > tunnel = 1; > > if (tunnel == 1) { > + if (testpmd_ol_flags & > + TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > + ol_flags |= PKT_TX_UDP_TUNNEL_PKT; > + > outer_ethertype = ethertype; > outer_l2_len = l2_len; > outer_l3_len = l3_len; > Can you explain why you are moving this code? Regards, Olivier