From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 4A3B3255 for ; Mon, 26 Jan 2015 15:07:25 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YFkNX-0002fN-Lq; Mon, 26 Jan 2015 15:11:03 +0100 Message-ID: <54C64A10.2010906@6wind.com> Date: Mon, 26 Jan 2015 15:07:12 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: "Liu, Jijiang" , "Ananyev, Konstantin" , "Zhang, Helin" References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA85A1@SHSMSX101.ccr.corp.intel.com> <54B3B35A.5030803@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA8E36@SHSMSX101.ccr.corp.intel.com> <54B4EB92.40209@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB0789@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213D4FCF@irsmsx105.ger.corp.intel.com> <54B94A18.5030700@6wind.com> <2601191342CEEE43887BDE71AB977258213DCD25@irsmsx105.ger.corp.intel.com> <54BD16F1.6050409@6wind.com> <2601191342CEEE43887BDE71AB977258213DDF46@irsmsx105.ger.corp.intel.com> <54BE4C70.7050406@6wind.com> <2601191342CEEE43887BDE71AB977258213DE5FB@irsmsx105.ger.corp.intel.com> <54BE9B56.7050108@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB55DB@SHSMSX101.ccr.corp.intel.com> <54BFC4D6.2010903@6wind.com> <2601191342CEEE43887BDE71AB977258213DF71B@irsmsx105.ger.corp.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6FD2@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6FD2@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2015 14:07:25 -0000 Hi, On 01/26/2015 07:02 AM, Liu, Jijiang wrote: >> I tried to repeat Olivier test-cases on my box. >> Though, I didn't use test-pmd cusmonly and i40ePMD logic, but filled TCD and >> TDD mostly from hardcoded values. >> That's what I got: >> >> 4 input packets: >> a) ETHER/IPv4/UDP/VXLAN/ETHER/IPV4/TCP >> b) ETHER/IPv4/GRE/ETHER/IPV4/TCP >> c) ETHER/IPv4/GRE/IPV4/TCP >> d) ETHER/IPv4/IPV4/TCP >> >> 1/ L4TUNT==1(I40E_TXD_CTX_UDP_TUNNELING): >> a),b): all checksums ok >> c),d): not transmitted by HW. >> >> 2/ L4TUNT==2(I40E_TXD_CTX_GRE_TUNNELING): >> a) b),c): all checksums ok >> d): not transmitted by HW. >> >> 3/ L4TUNT==0(UNKNOWN): >> a),b),c),d): all checksums ok >> >> So yes, it seems that L4TUNT==0 works perfectly ok for all cases, as long as >> L4TUNLEN and other TCD values are setup properly. >> Which makes me think, that probably we can do what you suggested: just use >> L4TUNT=0 for all cases. >> Though as Jijiang said, we waiting for confirmation from FVL guys, that there are >> no hidden implications with that approach. > > Yes, the L4TUNT=0 is ok for all cases. Great! Thanks for testing on your side too. > But we still need to get confirmation from FVL guys, probably there are some issues in HW/FW. > I and Helin will confirm this with FVL guys ASAP. OK, thank you. >> Another thing - IPIP seems to work ok by HW. >> There is something wrong on our (PMD/test-pmd) side. >> I think at least we have to remove the following check: >> if (!l2_len) { >> PMD_DRV_LOG(DEBUG, "L2 length set to 0"); >> return; >> } >> in i40e_txd_enable_checksum(). > > Yes, for IPIP, the check should be removed. Yes, I think these lines should be removed for 2 reasons: - it may be the cause of ipip tunnel not working - we shouldn't do these kind of tests in dataplane. I think we have to suppose that the data passed to the PMD is valid. I'll redo the test with ipip tomorrow with this fix and let you know the result. If it works, I'll add this in the next version of the patch. Regards, Olivier