From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5C9D85F12 for ; Tue, 27 Jan 2015 09:34:37 +0100 (CET) Received: by mail-wg0-f45.google.com with SMTP id x12so13389051wgg.4 for ; Tue, 27 Jan 2015 00:34:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+DbzUZ7RbWIt6DZb0P+UOzYlGya02sf6bPv9Nc4Ifvg=; b=HvGarq8+t0J6bg4nqGfKmgrEScJn3Rxz9I7zYxT75C5y5r17JP+5Pl+emQnUhNEoSs lJA/dFhxv45FIZwvbE3UTspaRoGMZXOUVUXpoRb73ZUPMb1ghNIhWG1HIpGYDw2C4WrJ IEsz2n+Eogqh/4X/SEF737Tsyblt7jiJoLOYlnPj8f4/T2dIHuWev04coHoGzhEwQCjw gLbdq93L0/8HPP9/Nkww5yiHK/UYZyTgv+WtXGzylwJW3CpyPYbJAhL15Z0o7sRurZUC XCjaUN/UDVtUbm44k7E7oN/OhB7Bswmf7JS0ZRTizQSgxM7m7rfbSsD9BoZZXQ2i/W0x UHUg== X-Gm-Message-State: ALoCoQmNytUJQWxhzaA8ZlSHAa4FcBP9M9xbpidfwzmG13KN79+tAX4PHIco2rdIlQoJ9yRVanfT X-Received: by 10.180.206.147 with SMTP id lo19mr35504250wic.32.1422347677156; Tue, 27 Jan 2015 00:34:37 -0800 (PST) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id u18sm791876wjq.42.2015.01.27.00.34.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2015 00:34:36 -0800 (PST) Message-ID: <54C74D80.7090208@6wind.com> Date: Tue, 27 Jan 2015 09:34:08 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , "Liu, Jijiang" , "Zhang, Helin" References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA8E36@SHSMSX101.ccr.corp.intel.com> <54B4EB92.40209@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB0789@SHSMSX101.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258213D4FCF@irsmsx105.ger.corp.intel.com> <54B94A18.5030700@6wind.com> <2601191342CEEE43887BDE71AB977258213DCD25@irsmsx105.ger.corp.intel.com> <54BD16F1.6050409@6wind.com> <2601191342CEEE43887BDE71AB977258213DDF46@irsmsx105.ger.corp.intel.com> <54BE4C70.7050406@6wind.com> <2601191342CEEE43887BDE71AB977258213DE5FB@irsmsx105.ger.corp.intel.com> <54BE9B56.7050108@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB55DB@SHSMSX101.ccr.corp.intel.com> <54BFC4D6.2010903@6wind.com> <2601191342CEEE43887BDE71AB977258213DF71B@irsmsx105.ger.corp.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB6FD2@SHSMSX101.ccr.corp.intel.com> <54C64A10.2010906@6wind.com> <2601191342CEEE43887BDE71AB977258213DF90B@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258213DF90B@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 08:34:37 -0000 Hi Konstantin, On 01/26/2015 03:15 PM, Ananyev, Konstantin wrote: >>>> Another thing - IPIP seems to work ok by HW. >>>> There is something wrong on our (PMD/test-pmd) side. >>>> I think at least we have to remove the following check: >>>> if (!l2_len) { >>>> PMD_DRV_LOG(DEBUG, "L2 length set to 0"); >>>> return; >>>> } >>>> in i40e_txd_enable_checksum(). >>> >>> Yes, for IPIP, the check should be removed. >> >> Yes, I think these lines should be removed for 2 reasons: >> - it may be the cause of ipip tunnel not working >> - we shouldn't do these kind of tests in dataplane. I think we have to >> suppose that the data passed to the PMD is valid. >> >> I'll redo the test with ipip tomorrow with this fix and let you >> know the result. If it works, I'll add this in the next version >> of the patch. > > While you are on this, can I suggest you'll add debug logging for TCD and TDD we are writing to the TX ring? > Something like that: > > + PMD_TX_LOG(DEBUG, "mbuf: %p, TCD[%u]:\n" > + "tunneling_params: %#x;\n" > + "l2tag2: %#hx;\n" > + "rsvd: %#hx;\n" > + "type_cmd_tso_mss: %#lx;\n", > + tx_pkt, tx_id, > + ctx_txd->tunneling_params, > + ctx_txd->l2tag2, > + ctx_txd->rsvd, > + ctx_txd->type_cmd_tso_mss); > > And same for TDD. > It helped me a lot to figure out what is going on, when I did my tests. > Probably would be useful for other people too. Sure, I'll add this. Also, just to let you know that I tested the ipip case without the "if (l2_len) return" and "if (l3_len) return", and it is working. Regards, Olivier