From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by dpdk.org (Postfix) with ESMTP id 908E9234 for ; Fri, 30 Jan 2015 11:02:50 +0100 (CET) Received: by mail-pa0-f48.google.com with SMTP id ey11so50695995pad.7 for ; Fri, 30 Jan 2015 02:02:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=pzGarBh2PlIUI1A7EBeAtLMqeS4ufbSQqbgfy28GBZs=; b=aDQdvxFo7+BP2ZRn/v+ikSCDZv1hs4t884EPEXwXCQPb2EKI98Rt3e4Elk59I9DJrs 0gZZxSw66yCRVhBKHphtvjmqHQDORHJp8tG/OAHN6AvtxdqMWksGPY9QcFXBrBsJsLtJ JmDpnn7mEIOqRjD9Nhf2BUTThW7owGJvHNmwC+IFyOXFTTppFqPQhCcgxImMdoJygQ7l pwQjtN6xtTkLRDANadbDdFOELIlB1RzRpw8dle4uDP0qwJbDeeDP+mpTsmvowkUg2Wu0 vwASdyH7Qh7RLrmImxt4Sni3VEb0FVfAC4BvTLq7+mq5wNmWy6heHSKDahwbVN656TM9 HwEg== X-Gm-Message-State: ALoCoQlRIGfxRzI9V+dhmZo50iG/q5OnI3SG9Xgvq93gvpWrBldf6lyCXZGp2nbamlinTccogDqs X-Received: by 10.68.132.134 with SMTP id ou6mr7801648pbb.118.1422612169859; Fri, 30 Jan 2015 02:02:49 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id k5sm10279199pdn.45.2015.01.30.02.02.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 02:02:49 -0800 (PST) Message-ID: <54CB56C8.8060600@igel.co.jp> Date: Fri, 30 Jan 2015 19:02:48 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Huawei Xie , dev@dpdk.org References: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> In-Reply-To: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 00/12] qemu vhost-user support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 10:02:51 -0000 On 2015/01/30 15:36, Huawei Xie wrote: > vhost-user supports passing vring information to a seperate vhost enabled > process, normally a user space vSwitch, through unix domain socket. > > In previous DPDK version, we implement a user space character device driver > vhost-cuse in user space DPDK process. vring informations are passed to the > driver through ioctl call, including eventfds for interrupt injection and > host notification. We need to develop a kernel module to copy that fd from > qemu into our process. We also need some trick to map guest memory. > (TODO: kickfd/callfd is reversed which causes confusion) > > known issue in vhost-user implementation in QEMU, reported by haifeng.lin@huawei.com > * QEMU doesn't send correct memory region information with multiple numa node configuration > http://lists.gnu.org/archive/html/qemu-devel/2014-12/msg01454.html > > Thanks Tetsuya for reporting the issue that "FD_ISSET would crash when receive -1 > as fd on Ubuntu 14.04". > > Huawei Xie (12): > enable VIRTIO_NET_F_CTRL_RX > create vhost_cuse directory and move vhost-net-cdev.c into vhost_cuse > rename vhost-net-cdev.h to vhost-net.h > move fd copying(from qemu process into vhost process) to eventfd_copy.c > copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c > make host_memory_map more generic > split set_memory_table into two parts > add select based event driven processing > free memory when receive new set_memory_table message > vhost user support > support dev->ifname in vhost-user > support calling rte_vhost_driver_register after rte_vhost_driver_session_start > > lib/librte_vhost/Makefile | 8 +- > lib/librte_vhost/rte_virtio_net.h | 5 +- > lib/librte_vhost/vhost-net-cdev.c | 389 --------------------- > lib/librte_vhost/vhost-net-cdev.h | 113 ------- > lib/librte_vhost/vhost-net.h | 121 +++++++ > lib/librte_vhost/vhost_cuse/eventfd_copy.c | 89 +++++ > lib/librte_vhost/vhost_cuse/eventfd_copy.h | 40 +++ > lib/librte_vhost/vhost_cuse/vhost-net-cdev.c | 417 +++++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.c | 401 ++++++++++++++++++++++ > lib/librte_vhost/vhost_cuse/virtio-net-cdev.h | 48 +++ > lib/librte_vhost/vhost_rxtx.c | 2 +- > lib/librte_vhost/vhost_user/fd_man.c | 234 +++++++++++++ > lib/librte_vhost/vhost_user/fd_man.h | 66 ++++ > lib/librte_vhost/vhost_user/vhost-net-user.c | 469 ++++++++++++++++++++++++++ > lib/librte_vhost/vhost_user/vhost-net-user.h | 106 ++++++ > lib/librte_vhost/vhost_user/virtio-net-user.c | 322 ++++++++++++++++++ > lib/librte_vhost/vhost_user/virtio-net-user.h | 49 +++ > lib/librte_vhost/virtio-net.c | 455 +++---------------------- > lib/librte_vhost/virtio-net.h | 43 +++ > 19 files changed, 2460 insertions(+), 917 deletions(-) > delete mode 100644 lib/librte_vhost/vhost-net-cdev.c > delete mode 100644 lib/librte_vhost/vhost-net-cdev.h > create mode 100644 lib/librte_vhost/vhost-net.h > create mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.c > create mode 100644 lib/librte_vhost/vhost_cuse/eventfd_copy.h > create mode 100644 lib/librte_vhost/vhost_cuse/vhost-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.c > create mode 100644 lib/librte_vhost/vhost_cuse/virtio-net-cdev.h > create mode 100644 lib/librte_vhost/vhost_user/fd_man.c > create mode 100644 lib/librte_vhost/vhost_user/fd_man.h > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/vhost-net-user.h > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.c > create mode 100644 lib/librte_vhost/vhost_user/virtio-net-user.h > create mode 100644 lib/librte_vhost/virtio-net.h > Hi Xie, it seems "checkpath.pl" reports warnings in some patches. I guess some of them can be fixed. Thanks, Tetsuya