From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 7BAEE58CB for ; Fri, 30 Jan 2015 11:03:15 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id lj1so50587411pab.6 for ; Fri, 30 Jan 2015 02:03:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=MIrxJgd85+BV542YZS5Cp+NLP6sRGgyC6NhWiksyvvY=; b=bG5cBmdh/Y8jhiz/AR3cRg/a6hg6NjTFiu29UThEb5UnKNFye+wTJfmQZGilfyuWAo V9CntZ2a6dJlEEKA63e0xu4A5HKuzndJKviw5z8CYvmGPUHPLh/CCV4TSy4v5tT8Y0Bm qMuQBXBZ0T9AJosky2T9I47wxEzz817lFoptRm5DaK+7JNlt9oAn/nZj75soXnQI01VC sRsIGIGxmg/Ntup2l1zxQK0Z7PR+LFd0HGjEBT9lCurRrh+1BI4OhOGtUy986IQTpD9B qA/ZFg4m3I5ex9a6aIcz3LijJkj1zh4V1Fr8qXN4p/UHZHfuHZqsUVaZaF5HT4KiBkbg igEQ== X-Gm-Message-State: ALoCoQlLH/08ytzxdcd+J44pXqwNNW5p/AdJujw6x1yiL5h0aQLNvsTPn89OuDMAsxnnsUARUTSR X-Received: by 10.68.201.201 with SMTP id kc9mr7627499pbc.79.1422612194843; Fri, 30 Jan 2015 02:03:14 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id w9sm10293557pbt.10.2015.01.30.02.03.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 02:03:14 -0800 (PST) Message-ID: <54CB56E1.1030402@igel.co.jp> Date: Fri, 30 Jan 2015 19:03:13 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Huawei Xie , dev@dpdk.org References: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> <1422599787-12009-2-git-send-email-huawei.xie@intel.com> In-Reply-To: <1422599787-12009-2-git-send-email-huawei.xie@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 01/12] lib/librte_vhost: enable VIRTIO_NET_F_CTRL_RX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 10:03:15 -0000 On 2015/01/30 15:36, Huawei Xie wrote: > VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. > > Observed that virtio-net driver in guest would crash with only CTRL_RX = enabled. > > In virtnet_send_command: > > /* Caller should know better */ > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) || > (out + in > VIRTNET_SEND_COMMAND_SG_MAX)); > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/virtio-net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-ne= t.c > index b041849..52b4957 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -73,7 +73,8 @@ static struct virtio_net_config_ll *ll_root; > =20 > /* Features supported by this lib. */ > #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \= > - (1ULL << VIRTIO_NET_F_CTRL_RX)) > + (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ > + (1ULL << VIRTIO_NET_F_CTRL_RX)) > static uint64_t VHOST_FEATURES =3D VHOST_SUPPORTED_FEATURES; > =20 > /* Line size for reading maps file. */ Hi Xie, Could you please check below code? --------------------- examples/vhost/main.c --------------------- case 'P': promiscuous =3D 1; vmdq_conf_default.rx_adv_conf.vmdq_rx_conf.rx_mod= e =3D ETH_VMDQ_ACCEPT_BROADCAST | ETH_VMDQ_ACCEPT_MULTICAST; rte_vhost_feature_enable(1ULL << VIRTIO_NET_F_CTRL_RX); VIRTIO_NET_F_CTRL_RX is always enabled by this patch. So if 'P' isn't specified in vhost example, does it need to be disabled? Thanks, Tetsuya