DPDK patches and discussions
 help / color / mirror / Atom feed
From: Linhaifeng <haifeng.lin@huawei.com>
To: Huawei Xie <huawei.xie@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC PATCH v2 01/14] enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver in guest would crash with only CTRL_RX enabled.
Date: Fri, 30 Jan 2015 19:59:04 +0800	[thread overview]
Message-ID: <54CB7208.6040903@huawei.com> (raw)
In-Reply-To: <1422242440-28948-2-git-send-email-huawei.xie@intel.com>



On 2015/1/26 11:20, Huawei Xie wrote:
> In virtnet_send_command:
> 
> 	/* Caller should know better */
> 	BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) ||
> 		(out + in > VIRTNET_SEND_COMMAND_SG_MAX));
> 
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> ---
>  lib/librte_vhost/virtio-net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
> index b041849..52b4957 100644
> --- a/lib/librte_vhost/virtio-net.c
> +++ b/lib/librte_vhost/virtio-net.c
> @@ -73,7 +73,8 @@ static struct virtio_net_config_ll *ll_root;
>  
>  /* Features supported by this lib. */
>  #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \
> -				  (1ULL << VIRTIO_NET_F_CTRL_RX))
> +				(1ULL << VIRTIO_NET_F_CTRL_VQ) | \
> +				(1ULL << VIRTIO_NET_F_CTRL_RX))
>  static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES;
>  
>  /* Line size for reading maps file. */
> 

Hi,Xie

If don't have features VIRTIO_NET_F_CTRL_VQ and  VIRTIO_NET_F_CTRL_RX what would happen?
Why add the two features?
-- 
Regards,
Haifeng

  reply	other threads:[~2015-01-30 11:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  3:20 [dpdk-dev] [RFC PATCH v2 00/14] qemu vhost-user support Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 01/14] enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver in guest would crash with only CTRL_RX enabled Huawei Xie
2015-01-30 11:59   ` Linhaifeng [this message]
2015-01-31 15:24     ` Xie, Huawei
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 02/14] create vhost_cuse sub-directory create vhost_cuse directory move vhost-net-cdev.c to vhost_cuse directory Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 03/14] rename vhost-net-cdev.h to vhost-net.h Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 04/14] consistent print style Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 05/14] implement eventfd copying(from fd in qemu process to fd in vhost process) in vhost-net-cdev.c Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 06/14] copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 07/14] host_memory_map Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 08/14] split set_memory_table into two parts Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 09/14] add select based event driven fd management logic Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 10/14] vhost user support Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 11/14] vhost user memory region map Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 12/14] cleanup when vhost user connection is closed Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 13/14] multiple socket support Huawei Xie
2015-01-26  3:20 ` [dpdk-dev] [RFC PATCH v2 14/14] vhost user ifr_name support Huawei Xie
2015-02-09  7:52 ` [dpdk-dev] [RFC PATCH v2 00/14] qemu vhost-user support Linhaifeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CB7208.6040903@huawei.com \
    --to=haifeng.lin@huawei.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).