From: Declan Doherty <declan.doherty@intel.com>
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] bond: fix 'extern "C"' decls in mode4 header files
Date: Fri, 30 Jan 2015 13:35:52 +0000 [thread overview]
Message-ID: <54CB88B8.90602@intel.com> (raw)
In-Reply-To: <1422624071-12437-1-git-send-email-pawelx.wodkowski@intel.com>
On 30/01/15 13:21, Pawel Wodkowski wrote:
> v2:
> Remove 'extern "C"' declarations from bond private header files.
>
> v1:
> Add missing declarations to rte_bond_8023ad.h.
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> ---
> lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 ++++++++
> lib/librte_pmd_bond/rte_eth_bond_private.h | 8 --------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> index 9adc6aa..ebd0e93 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> @@ -36,6 +36,10 @@
>
> #include <rte_ether.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> /**
> * Actor/partner states
> */
> @@ -211,4 +215,8 @@ int
> rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
> struct rte_eth_bond_8023ad_slave_info *conf);
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
> #endif /* RTE_ETH_BOND_8023AD_H_ */
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_private.h b/lib/librte_pmd_bond/rte_eth_bond_private.h
> index e01e66b..3da5a9e 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_private.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_private.h
> @@ -34,10 +34,6 @@
> #ifndef _RTE_ETH_BOND_PRIVATE_H_
> #define _RTE_ETH_BOND_PRIVATE_H_
>
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
> #include <rte_ethdev.h>
> #include <rte_spinlock.h>
>
> @@ -276,8 +272,4 @@ int
> bond_ethdev_parse_time_ms_kvarg(const char *key __rte_unused,
> const char *value, void *extra_args);
>
> -#ifdef __cplusplus
> -}
> -#endif
> -
> #endif
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
prev parent reply other threads:[~2015-01-30 13:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 12:45 [dpdk-dev] [PATCH] Added missing extern 'C' " Pawel Wodkowski
2015-01-30 10:20 ` Thomas Monjalon
2015-01-30 10:56 ` Wodkowski, PawelX
2015-01-30 11:42 ` Declan Doherty
2015-01-30 12:11 ` Wodkowski, PawelX
2015-01-30 12:15 ` Declan Doherty
2015-01-30 13:21 ` [dpdk-dev] [PATCH v2] bond: fix 'extern "C"' " Pawel Wodkowski
2015-01-30 13:35 ` Declan Doherty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CB88B8.90602@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pawelx.wodkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).