From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id DC5492E8D
for <dev@dpdk.org>; Fri, 30 Jan 2015 14:33:35 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga101.fm.intel.com with ESMTP; 30 Jan 2015 05:33:22 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="447525669"
Received: from dwdohert-dpdk-fedora-20.ir.intel.com ([163.33.213.98])
by FMSMGA003.fm.intel.com with ESMTP; 30 Jan 2015 05:19:29 -0800
Message-ID: <54CB88B8.90602@intel.com>
Date: Fri, 30 Jan 2015 13:35:52 +0000
From: Declan Doherty <declan.doherty@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>, dev@dpdk.org
References: <1422362703-18868-1-git-send-email-pawelx.wodkowski@intel.com>
<1422624071-12437-1-git-send-email-pawelx.wodkowski@intel.com>
In-Reply-To: <1422624071-12437-1-git-send-email-pawelx.wodkowski@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] bond: fix 'extern "C"' decls in mode4
header files
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jan 2015 13:33:36 -0000
On 30/01/15 13:21, Pawel Wodkowski wrote:
> v2:
> Remove 'extern "C"' declarations from bond private header files.
>
> v1:
> Add missing declarations to rte_bond_8023ad.h.
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> ---
> lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 ++++++++
> lib/librte_pmd_bond/rte_eth_bond_private.h | 8 --------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> index 9adc6aa..ebd0e93 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
> @@ -36,6 +36,10 @@
>
> #include <rte_ether.h>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> /**
> * Actor/partner states
> */
> @@ -211,4 +215,8 @@ int
> rte_eth_bond_8023ad_slave_info(uint8_t port_id, uint8_t slave_id,
> struct rte_eth_bond_8023ad_slave_info *conf);
>
> +#ifdef __cplusplus
> +}
> +#endif
> +
> #endif /* RTE_ETH_BOND_8023AD_H_ */
> diff --git a/lib/librte_pmd_bond/rte_eth_bond_private.h b/lib/librte_pmd_bond/rte_eth_bond_private.h
> index e01e66b..3da5a9e 100644
> --- a/lib/librte_pmd_bond/rte_eth_bond_private.h
> +++ b/lib/librte_pmd_bond/rte_eth_bond_private.h
> @@ -34,10 +34,6 @@
> #ifndef _RTE_ETH_BOND_PRIVATE_H_
> #define _RTE_ETH_BOND_PRIVATE_H_
>
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -
> #include <rte_ethdev.h>
> #include <rte_spinlock.h>
>
> @@ -276,8 +272,4 @@ int
> bond_ethdev_parse_time_ms_kvarg(const char *key __rte_unused,
> const char *value, void *extra_args);
>
> -#ifdef __cplusplus
> -}
> -#endif
> -
> #endif
>
Acked-by: Declan Doherty <declan.doherty@intel.com>