From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D8A1C4A63 for ; Thu, 30 Mar 2017 17:14:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490886865; x=1522422865; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fzSUiGI+AZoFhDQIBJlA0ARy2W4c4+gPjTcwyTqI9TY=; b=D6Ny0V1reowkYNcGa4WjkEl2qqpTI32j2Z25eRtRB0gE1hPUGHiQMFfe pFo40V9sKnDZmNL3OukNOA1OpkSAVg==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 08:14:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="949835554" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 30 Mar 2017 08:14:22 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by IRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 16:14:21 +0100 From: "Singh, Jasvinder" To: Olivier Matz , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v8 1/2] librte_net: add crc compute APIs Thread-Index: AQHSqUe8JDUE4qmTH0C0FzoME/bgZaGtLyMAgAA0xwCAABk/MA== Date: Thu, 30 Mar 2017 15:14:21 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D31B4472D@IRSMSX103.ger.corp.intel.com> References: <1490807704-211859-2-git-send-email-jasvinder.singh@intel.com> <1490873422-13734-1-git-send-email-jasvinder.singh@intel.com> <1490873422-13734-2-git-send-email-jasvinder.singh@intel.com> <2601191342CEEE43887BDE71AB9772583FAE243B@IRSMSX109.ger.corp.intel.com> <20170330164048.1c92bf81@platinum> In-Reply-To: <20170330164048.1c92bf81@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2YxODA5MTctOGEyYS00OGRhLTgzYWMtOTY2NzliMmU2NzcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZNXC96Z1AxOWNuUEFHWmg4R21LWDY3OHFOYUROVkhDb0JBVEFhdGpPYWZVPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 1/2] librte_net: add crc compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 15:14:25 -0000 Hi Olivier, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Thursday, March 30, 2017 3:41 PM > To: Ananyev, Konstantin > Cc: Singh, Jasvinder ; dev@dpdk.org; Doherty, > Declan ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v8 1/2] librte_net: add crc compute APIs > I think this include should not be included from rte_net_crc.h. >=20 > From what I see, the API is the same for sse and non-sse, so this include > could be private, included only from the .c file. If you also remove the = include > to rte_mbuf.h as suggested by Konstantin, it will require the following > includes in rte_net_crc.c: >=20 > #include > #include >=20 > #include > #include > #include > #include > #include > #if defined(RTE_ARCH_X86_64) && > defined(RTE_MACHINE_CPUFLAG_SSE4_2) > #include > #endif >=20 > If the sse file is only used in the .c, this line could also be removed i= n the > Makefile: >=20 > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D rte_net_crc_sse.h >=20 >=20 > I'm not very familiar with crc and sse code. Could you add yourself as > maintainer for these files in MAINTAINERS? >=20 >=20 > Thanks > Olivier Thank you for the review. I will make above suggested changes in the next v= ersion.=20 Jasvinder