From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3CD941DB1 for ; Wed, 5 Apr 2017 21:22:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491420166; x=1522956166; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qddm5IE+DGtaMWptj7vgNQ1NFQDXDKavtT2ofg1FmIs=; b=Y4l7GzxjaDh93X6jE3JU6dxplagDchhs6B0DGUcD5NYKODL6Ln4d0KQB JqLZLhGTZq2/4G+MxI1tgBAzieYQIw==; Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 12:22:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,280,1488873600"; d="scan'208";a="1151575173" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2017 12:22:43 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by IRSMSX151.ger.corp.intel.com ([169.254.4.123]) with mapi id 14.03.0319.002; Wed, 5 Apr 2017 20:22:43 +0100 From: "Singh, Jasvinder" To: Thomas Monjalon CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "Doherty, Declan" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs Thread-Index: AQHSrhvbGiu2Zx0MfEukoGN6xOuYRKG2/QeAgAAqXZA= Date: Wed, 5 Apr 2017 19:22:42 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D31B49B72@IRSMSX103.ger.corp.intel.com> References: <1490890533-92231-2-git-send-email-jasvinder.singh@intel.com> <1491404326-89256-1-git-send-email-jasvinder.singh@intel.com> <1491404326-89256-2-git-send-email-jasvinder.singh@intel.com> <1806652.2aVc4LrPS0@xps13> In-Reply-To: <1806652.2aVc4LrPS0@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTkyODViYWUtZDBhMS00OGU4LWFmMmEtMjVmODIxMzYxOWQ3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ijd0eTgwRmN4QWxSKzA0SEkwa2Q4Wm1TWE5pUDNVQmdjY0ZQNmF5UEp0VlE9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 19:22:46 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, April 5, 2017 6:50 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; olivier.matz@6wind.com; Doherty, Declan > ; De Lara Guarch, Pablo > > Subject: Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs >=20 > 2017-04-05 15:58, Jasvinder Singh: > > APIs for selecting the architecure specific implementation and > > computing the crc (16-bit and 32-bit CRCs) are added. For CRCs > > calculation, scalar as well as x86 intrinsic(sse4.2) versions are imple= mented. > > > > The scalar version is based on generic Look-Up Table(LUT) algorithm, > > while x86 intrinsic version uses carry-less multiplication for fast > > CRC computation. > > > > Signed-off-by: Jasvinder Singh > > Acked-by: Pablo de Lara >=20 > There is a remaining error with doxygen: > lib/librte_net/rte_net_crc_sse.h:153: > warning: documented symbol `static const uint8_t > crc_xmm_shift_tab' > was not declared or defined. >=20 > > --- a/lib/librte_net/Makefile > > +++ b/lib/librte_net/Makefile > > @@ -39,10 +39,12 @@ EXPORT_MAP :=3D rte_net_version.map LIBABIVER > :=3D 1 > > > > SRCS-$(CONFIG_RTE_LIBRTE_NET) :=3D rte_net.c > > +SRCS-$(CONFIG_RTE_LIBRTE_NET) +=3D rte_net_crc.c > > > > # install includes > > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include :=3D rte_ip.h rte_tcp.h > > rte_udp.h SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D rte_sctp.h > > rte_icmp.h rte_arp.h SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D > > rte_ether.h rte_gre.h rte_net.h > > +SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include +=3D rte_net_crc.h >=20 > As rte_net_crc_sse.h is not exported, you should avoid doxygen generation= . > I suggest removing the rte_ prefix of the filename, so it will make clear= that it > is a private header and doxygen should ignore it (because of FILE_PATTERN= S > =3D rte_*.h). Thanks, will fix above in next version.