From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AB6261B1F7 for ; Tue, 19 Sep 2017 17:07:01 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 08:06:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="1196791694" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 19 Sep 2017 08:06:45 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Sep 2017 16:06:44 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by irsmsx112.ger.corp.intel.com ([169.254.1.142]) with mapi id 14.03.0319.002; Tue, 19 Sep 2017 16:06:44 +0100 From: "Singh, Jasvinder" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode Thread-Index: AQHTLU5xHEcrTqypJUC9p28fUYOau6K6olUAgAG0VRA= Date: Tue, 19 Sep 2017 15:06:43 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D33254B08@IRSMSX103.ger.corp.intel.com> References: <20170822170240.8059-1-jasvinder.singh@intel.com> <20170914115302.33995-1-jasvinder.singh@intel.com> <20170914115302.33995-2-jasvinder.singh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQwNzAwZDktM2E5Ni00OTFlLTg2ZWQtMDAwZjBhODc0YWEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlUMkJ6TllndnhLQlhUcjNVZjF2bitBbEF2U3dheFU1aWVCZ1ROVkJmd2c9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for tm mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 15:07:02 -0000 > > Add following CLIs in testpmd application; > > - commands to build hierarchical tree for the QoS Scheduler. > > - commands for runtime update of the hierarchical tree. > > - commands to display TM capability information. > > (per port, per hierarchy level and per hierarchy node) > > - command to set the packet field mask and offset value for > > classification. > > - command to set traffic class translation table entry > > - stats collection >=20 > This patch should be split into multiple patches, as it is quite big and = it is > adding multiple commands that can be arranged in different categories, in > different patches. >=20 > Also, as you are adding several commands about traffic management, you > could separate these in a different file (i.e. cmdline_tm.c). Will split the patch into multiple. Thanks. > > > > Signed-off-by: Jasvinder Singh > > --- > > app/test-pmd/cmdline.c | 2975 > > ++++++++++++++++++++++++++++++++++++++++++++---- > > 1 file changed, 2785 insertions(+), 190 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > cd8c358..cb837ce 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c >=20 > ... >=20 > > + > > + /* Command type: add */ > > + if (strcmp(res->cmd_type, "add") =3D=3D 0) { > > + /* Port link status */ > > + rte_eth_link_get_nowait(port_id, &link); > > + if (link.link_status =3D=3D ETH_LINK_UP) { > > + printf(" Port %u link up (error)\n", port_id); > > + return; > > + } >=20 > If you are checking if the device is started or stopped, you should proba= bly > use "is_port_started" function. Ok, will change this. =20 > > + > > + /* TM hierarchy status */ > > + if (port->softport.tm.hierarchy_frozen =3D=3D 1) > > + port->softport.tm.hierarchy_frozen =3D 0; > > + } > > + > > + /* Command type: set (update) */