* [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table @ 2018-01-11 13:49 Tomasz Duszynski 2018-01-11 18:33 ` Dumitrescu, Cristian 2018-01-28 11:58 ` Tomasz Duszynski 0 siblings, 2 replies; 7+ messages in thread From: Tomasz Duszynski @ 2018-01-11 13:49 UTC (permalink / raw) To: dev; +Cc: wenzhuo.lu, jingjing.wu, Tomasz Duszynski Since METER action is supported by the testpmd application suitable entry should exist in flow actions information table. Without that testpmd will return error on adding a new flow to the list of flows attached to a given port. Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 0a84481..4ad19fb 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1038,6 +1038,7 @@ static const struct { MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* +queue[] */ MK_FLOW_ACTION(PF, 0), MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), }; /** Compute storage space needed by action configuration. */ -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-11 13:49 [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table Tomasz Duszynski @ 2018-01-11 18:33 ` Dumitrescu, Cristian 2018-01-12 13:07 ` Singh, Jasvinder 2018-01-28 11:58 ` Tomasz Duszynski 1 sibling, 1 reply; 7+ messages in thread From: Dumitrescu, Cristian @ 2018-01-11 18:33 UTC (permalink / raw) To: Tomasz Duszynski, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing, Singh, Jasvinder > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Thursday, January 11, 2018 1:49 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com> > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table > > Since METER action is supported by the testpmd application > suitable entry should exist in flow actions information table. > > Without that testpmd will return error on adding a new flow to > the list of flows attached to a given port. > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> > --- > app/test-pmd/config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 0a84481..4ad19fb 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1038,6 +1038,7 @@ static const struct { > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > +queue[] */ > MK_FLOW_ACTION(PF, 0), > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > }; > > /** Compute storage space needed by action configuration. */ > -- > 2.7.4 Adding Jasvinder to this thread. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-11 18:33 ` Dumitrescu, Cristian @ 2018-01-12 13:07 ` Singh, Jasvinder 2018-01-22 7:28 ` Tomasz Duszynski 0 siblings, 1 reply; 7+ messages in thread From: Singh, Jasvinder @ 2018-01-12 13:07 UTC (permalink / raw) To: Dumitrescu, Cristian, Tomasz Duszynski, dev; +Cc: Lu, Wenzhuo, Wu, Jingjing > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Thursday, January 11, 2018 6:34 PM > To: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > <jingjing.wu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com> > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > table > > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > Sent: Thursday, January 11, 2018 1:49 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com> > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > table > > > > Since METER action is supported by the testpmd application suitable > > entry should exist in flow actions information table. > > > > Without that testpmd will return error on adding a new flow to the > > list of flows attached to a given port. > > > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> > > --- > > app/test-pmd/config.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 0a84481..4ad19fb 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -1038,6 +1038,7 @@ static const struct { > > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > > +queue[] */ > > MK_FLOW_ACTION(PF, 0), > > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > > }; > > > > /** Compute storage space needed by action configuration. */ > > -- > > 2.7.4 > > Adding Jasvinder to this thread. The above change looks fine to me. Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-12 13:07 ` Singh, Jasvinder @ 2018-01-22 7:28 ` Tomasz Duszynski 0 siblings, 0 replies; 7+ messages in thread From: Tomasz Duszynski @ 2018-01-22 7:28 UTC (permalink / raw) To: Singh, Jasvinder Cc: Dumitrescu, Cristian, Tomasz Duszynski, dev, Lu, Wenzhuo, Wu, Jingjing On Fri, Jan 12, 2018 at 01:07:34PM +0000, Singh, Jasvinder wrote: > > > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Thursday, January 11, 2018 6:34 PM > > To: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > <jingjing.wu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com> > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > table > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > > Sent: Thursday, January 11, 2018 1:49 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing > > > <jingjing.wu@intel.com>; Tomasz Duszynski <tdu@semihalf.com> > > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > > table > > > > > > Since METER action is supported by the testpmd application suitable > > > entry should exist in flow actions information table. > > > > > > Without that testpmd will return error on adding a new flow to the > > > list of flows attached to a given port. > > > > > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> > > > --- > > > app/test-pmd/config.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > > 0a84481..4ad19fb 100644 > > > --- a/app/test-pmd/config.c > > > +++ b/app/test-pmd/config.c > > > @@ -1038,6 +1038,7 @@ static const struct { > > > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > > > +queue[] */ > > > MK_FLOW_ACTION(PF, 0), > > > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > > > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > > > }; > > > > > > /** Compute storage space needed by action configuration. */ > > > -- > > > 2.7.4 > > > > Adding Jasvinder to this thread. > > The above change looks fine to me. > > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> Since I cannot see any objections can you pick up this one? -- - Tomasz Duszyński ^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-11 13:49 [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table Tomasz Duszynski 2018-01-11 18:33 ` Dumitrescu, Cristian @ 2018-01-28 11:58 ` Tomasz Duszynski 2018-01-30 10:00 ` Adrien Mazarguil 1 sibling, 1 reply; 7+ messages in thread From: Tomasz Duszynski @ 2018-01-28 11:58 UTC (permalink / raw) To: dev; +Cc: wenzhuo.lu, jingjing.wu, jasvinder.singh, Tomasz Duszynski Since METER action is supported by the testpmd application suitable entry should exist in flow actions information table. Without that testpmd will return error on adding a new flow to the list of flows attached to a given port. Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 0a84481..4ad19fb 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1038,6 +1038,7 @@ static const struct { MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* +queue[] */ MK_FLOW_ACTION(PF, 0), MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), }; /** Compute storage space needed by action configuration. */ -- 2.7.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-28 11:58 ` Tomasz Duszynski @ 2018-01-30 10:00 ` Adrien Mazarguil 2018-01-31 22:43 ` Thomas Monjalon 0 siblings, 1 reply; 7+ messages in thread From: Adrien Mazarguil @ 2018-01-30 10:00 UTC (permalink / raw) To: Tomasz Duszynski; +Cc: dev, wenzhuo.lu, jingjing.wu, jasvinder.singh, stable On Sun, Jan 28, 2018 at 12:58:39PM +0100, Tomasz Duszynski wrote: > Since METER action is supported by the testpmd application > suitable entry should exist in flow actions information table. > > Without that testpmd will return error on adding a new flow to > the list of flows attached to a given port. > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> I think it's also candidate for: Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Cc: stable@dpdk.org Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> -- Adrien Mazarguil 6WIND ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table 2018-01-30 10:00 ` Adrien Mazarguil @ 2018-01-31 22:43 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2018-01-31 22:43 UTC (permalink / raw) To: Tomasz Duszynski Cc: dev, Adrien Mazarguil, wenzhuo.lu, jingjing.wu, jasvinder.singh, stable 30/01/2018 11:00, Adrien Mazarguil: > On Sun, Jan 28, 2018 at 12:58:39PM +0100, Tomasz Duszynski wrote: > > Since METER action is supported by the testpmd application > > suitable entry should exist in flow actions information table. > > > > Without that testpmd will return error on adding a new flow to > > the list of flows attached to a given port. > > > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com> > > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com> > > I think it's also candidate for: > > Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") > Cc: stable@dpdk.org > > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> Applied, thanks ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-31 22:44 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-11 13:49 [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table Tomasz Duszynski 2018-01-11 18:33 ` Dumitrescu, Cristian 2018-01-12 13:07 ` Singh, Jasvinder 2018-01-22 7:28 ` Tomasz Duszynski 2018-01-28 11:58 ` Tomasz Duszynski 2018-01-30 10:00 ` Adrien Mazarguil 2018-01-31 22:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).