From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 05D12D59A for ; Tue, 17 Apr 2018 18:33:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 09:33:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="34063163" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga007.jf.intel.com with ESMTP; 17 Apr 2018 09:33:37 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 17 Apr 2018 17:33:37 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by irsmsx112.ger.corp.intel.com ([169.254.1.226]) with mapi id 14.03.0319.002; Tue, 17 Apr 2018 17:33:36 +0100 From: "Singh, Jasvinder" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated Thread-Index: AQHT1lz+jYIkT6q/kUKBk9vtJwO38qQFHopA Date: Tue, 17 Apr 2018 16:33:36 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3333F500@IRSMSX101.ger.corp.intel.com> References: <20180417132825.148429-1-jasvinder.singh@intel.com> <20180417150114.GC89464@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20180417150114.GC89464@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmE2NmU3MDItYWE3Ni00OGFiLWI0NDItZDRmMmY4MDk2YzNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlV6empmUTdaMTB4Z1J0anhVSmE4VUUwTHozSUNtQWR2WlVmU0NkenVJUnc9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 16:33:40 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, April 17, 2018 4:01 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null > terminated >=20 > On Tue, Apr 17, 2018 at 02:28:25PM +0100, Jasvinder Singh wrote: > > The destination string may not have a null termination if the source > > string's length is equal to the sizeof(pipeline->name). > > > > Fix by replacing strncpy with strlcpy that guarantees NULL-termination. > > > > Coverty issue: 272606 > > Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") > > > > Signed-off-by: Jasvinder Singh >=20 > Does this need an include of rte_string_fns.h? >=20 > In terms of the change itself: >=20 > Acked-by: Bruce Richardson >=20 It got reference of rte_string_fns.h through other header files there. So b= uild was ok, but I will send v2 with explicit include. Thanks.