From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 250A92BA9 for ; Mon, 23 Apr 2018 11:04:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Apr 2018 02:04:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,317,1520924400"; d="scan'208";a="43903025" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 23 Apr 2018 02:04:13 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX154.ger.corp.intel.com (163.33.192.96) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Apr 2018 10:04:12 +0100 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by irsmsx111.ger.corp.intel.com ([169.254.2.167]) with mapi id 14.03.0319.002; Mon, 23 Apr 2018 10:04:12 +0100 From: "Singh, Jasvinder" To: "Zhang, Roy Fan" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" Thread-Topic: [PATCH v2] examples/ip_pipeline: fix uninitialized scalar variable Thread-Index: AQHT2LaKtn8jER6RikCI/xILR97z56QOEnXw Date: Mon, 23 Apr 2018 09:04:12 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D333469BC@IRSMSX101.ger.corp.intel.com> References: <20180416104751.65646-1-roy.fan.zhang@intel.com> <20180420143921.73335-1-roy.fan.zhang@intel.com> In-Reply-To: <20180420143921.73335-1-roy.fan.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzFiOWY1NzMtYTFjZi00YzRiLTg1MzQtN2U4ZjhmNzRhNmMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IktxQnBYNUJpM1FNS09MTEVqdTZSdVwvVEhHalpOd0pxS0pRTm1HYmRjZVwvdz0ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix uninitialized scalar variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 09:04:17 -0000 > -----Original Message----- > From: Zhang, Roy Fan > Sent: Friday, April 20, 2018 3:39 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinde= r > > Subject: [PATCH v2] examples/ip_pipeline: fix uninitialized scalar variab= le >=20 > Coverity issue: 272575 > Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object") >=20 > Signed-off-by: Fan Zhang > --- > v2: > - removed unecessary link.c update >=20 > examples/ip_pipeline/cli.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c inde= x > 199a31ff8..ec150ce4e 100644 > --- a/examples/ip_pipeline/cli.c > +++ b/examples/ip_pipeline/cli.c > @@ -138,6 +138,8 @@ cmd_link(char **tokens, > struct link *link; > char *name; >=20 > + memset(&p, 0, sizeof(p)); > + > if ((n_tokens < 13) || (n_tokens > 14 + LINK_RXQ_RSS_MAX)) { > snprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]); > return; > -- > 2.13.6 Reviewed-by: Jasvinder Singh