From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E909E1B3B7 for ; Tue, 26 Jun 2018 10:59:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 01:59:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="67780154" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 26 Jun 2018 01:59:23 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.136]) by IRSMSX102.ger.corp.intel.com ([169.254.2.146]) with mapi id 14.03.0319.002; Tue, 26 Jun 2018 09:59:22 +0100 From: "Singh, Jasvinder" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward mode Thread-Index: AQHUBMnrmaR9mxkY9kqB6Xyw2yV8R6RyPGcAgAARRNA= Date: Tue, 26 Jun 2018 08:59:22 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D335A8945@IRSMSX103.ger.corp.intel.com> References: <20180608124155.140663-2-jasvinder.singh@intel.com> <20180615165224.25004-1-jasvinder.singh@intel.com> <20180615165224.25004-23-jasvinder.singh@intel.com> <8CEF83825BEC744B83065625E567D7C260CB8923@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB8923@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWVmMDE2OTUtMTNmNC00ZDUyLWI0MmQtNDQxYWY0YmIxMzE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM3lqUVlWTnNIXC9DaXlhWkd5aCtEYlhyTDJZMjJDQ0tcL0F4OFR1dkVYbXlQSUpLYmZMYWF2WlNPOGZXMjhnbHd0In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 22/22] app/testpmd: rework softnic forward mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 08:59:25 -0000 Hi Bernard, > This patch fails to compile when applied the current dpdk 18_08 master. >=20 > /root/dpdk_sforge_2/app/test-pmd/cmdline.c: In function 'prompt': > /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: implicit > declaration of function 'rte_pmd_softnic_manage' [-Werror=3Dimplicit-func= tion- > declaration] > rte_pmd_softnic_manage(softnic_portid); > ^ > /root/dpdk_sforge_2/app/test-pmd/cmdline.c:17583:3: error: nested extern > declaration of 'rte_pmd_softnic_manage' [-Werror=3Dnested-externs] >=20 >=20 > It is also giving the following checkpatch errors and warnings: >=20 > WARNING: 'firware' may be misspelled - perhaps 'firmware'? > #24: > $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firware=3Dscript.cli' >=20 > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #33: > app/test-pmd/{tm.c =3D> softnicfwd.c} | 418 ++++++++++++----------------= -------- >=20 > WARNING: Missing a blank line after declarations > #107: FILE: app/test-pmd/cmdline.c:17554: > + uint8_t softnic_enable =3D 0; > + if (strcmp(cur_fwd_eng->fwd_mode_name, "softnic") =3D=3D 0) { >=20 > WARNING: line over 80 characters > #110: FILE: app/test-pmd/cmdline.c:17557: > + if (strcmp(port->dev_info.driver_name, > + "net_softnic") =3D=3D 0) { >=20 > WARNING: line over 80 characters > #163: FILE: app/test-pmd/config.c:2346: > + if (strcmp(port->dev_info.driver_name, > + "net_softnic") =3D=3D 0) { >=20 > ERROR: spaces required around that '=3D' (ctx:WxV) > #165: FILE: app/test-pmd/config.c:2348: > + softnic_enable =3D1; > ^ >=20 > WARNING: line over 80 characters > #171: FILE: app/test-pmd/config.c:2354: > + printf("Softnicfwd mode configuration not > + complete(%s)!\n", __func__); >=20 > ERROR: space required before the open parenthesis '(' > #208: FILE: app/test-pmd/config.c:2392: > + if(strcmp(cur_fwd_eng->fwd_mode_name, "softnic") =3D=3D 0) { >=20 > ERROR: space required before the open parenthesis '(' > #437: FILE: app/test-pmd/softnicfwd.c:150: > + for(;;) { >=20 > WARNING: void function return statements are not generally useful > #445: FILE: app/test-pmd/softnicfwd.c:158: > + return; > +} >=20 > ERROR: open brace '{' following function definitions go on the next line > #449: FILE: app/test-pmd/softnicfwd.c:162: > +static int > +softnic_begin(void *arg __rte_unused) { >=20 > ERROR: space required before the open parenthesis '(' > #456: FILE: app/test-pmd/softnicfwd.c:169: > + } while(!softnic_fwd_lcore->stopped); >=20 > WARNING: void function return statements are not generally useful > #713: FILE: app/test-pmd/softnicfwd.c:683: > + return; > +} >=20 > WARNING: adding a line without newline at end of file > #722: FILE: app/test-pmd/softnicfwd.c:690: > +}; >=20 > WARNING: line over 80 characters > #749: FILE: app/test-pmd/testpmd.c:823: > + if (strcmp(port->dev_info.driver_name, > + "net_softnic") =3D=3D 0) >=20 > total: 5 errors, 10 warnings, 768 lines checked >=20 > Regards, >=20 > Bernard I am about to send v3 which will address above issues. Thanks you. Jasvinder=20