From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 51F25F72 for ; Wed, 25 Jul 2018 10:31:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 01:31:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="57009740" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga007.fm.intel.com with ESMTP; 25 Jul 2018 01:30:59 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 09:30:58 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.208]) by irsmsx111.ger.corp.intel.com ([169.254.2.118]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 09:30:58 +0100 From: "Singh, Jasvinder" To: Thomas Monjalon , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , Mordechay Haimovsky , "Iremonger, Bernard" , "Pattan, Reshma" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d Thread-Index: AQHUInJHwCIvXKBOeEqCRJ5meRvhm6SeLF2AgAATHYCAACKJAIAAJ7IAgAEA2oCAABJboA== Date: Wed, 25 Jul 2018 08:30:58 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D335DD24E@IRSMSX103.ger.corp.intel.com> References: <20180723104425.10090-1-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E7792AF@IRSMSX107.ger.corp.intel.com> <1707406.j7eEjrHijo@xps> In-Reply-To: <1707406.j7eEjrHijo@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGJhNWIyNWYtMzFjYi00N2JiLWEwYTctMzhmNGZhN2M5NWE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieEhjXC9rSFl3NUpJTHBLT25zS1JSbVh6ZkJMQWJ3N2o3aVlLUDNDYW1UN0g4bkpibVpJTmN6NHpjRzVnbFBnXC9EIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 08:31:03 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, July 25, 2018 9:19 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Mordechay Haimovsky ; Singh, > Jasvinder ; Iremonger, Bernard > ; Pattan, Reshma > ; olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+= d >=20 > 24/07/2018 18:59, Dumitrescu, Cristian: > > From: Mordechay Haimovsky [mailto:motih@mellanox.com] > > > > > > Even after this fix we still have setups that use netvsc for > > > example, on which testpmd exits with rte_panic right after loading > > > it even without touching the KBD. > > > > > > I recommend returning the previous prompt routine in > > > test-pmd/cmdline.c and rework the SOFTNIC section there, preferably > > > moving its poll section to use rte_service in a separate file > > > cleaning the CLI files from PMD-specific implementation. > > > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > > > > > Important note: > > > > testpmd is currently really broken. > > > > We cannot have a RC2 until it is fixed. > > > > > > > > First, testpmd is not really broken, as only thing that changed is the = Ctrl + D > behavior. I agree this is an issue that we need to fix, as it looks that = it is > breaking some automation scripts for some people. > > > > The change in behavior for Ctrl + D exit is caused by replacing the cal= l to > cmdline_interact() with calling cmdline_poll() in a loop. These two appro= aches > should be identical in behavior, but it looks like they are not due to so= me issue > in the cmdline library. Jasvinder proposed a quick patch, but it looks li= ke > something else needs to be fixed in cmdline library in order to bring > cmdline_poll() on parity with cmdline_interact(). Any advice from Olivier= would > be very much appreciated! > > > > It is really a bad practice to use cmdline_interact() in testpmd, as it= is a > blocking call that prohibits doing other things on the same thread that r= uns the > CLI. Sometimes we need to run other things on the same core, e.g. the slo= w > softnic_manage() function. > > > > Worst case scenario: We can revert the cmdline_poll() back to > cmdline_interact(), this is a small change, but not the proper way of doi= ng > things, as this is simply hiding the issue in cmdline library. It would a= lso prevent > us from testing some Soft NIC functionality. >=20 > There are some crashes, even without touching the keyboard. Thomas, could you be specific here so that we can reproduce the issues you = are mentioning? Thanks. > So yes, we should revert. >=20