From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 320AB1B1F2 for ; Tue, 25 Sep 2018 16:20:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 07:20:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="94662881" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 25 Sep 2018 07:20:41 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.234]) by IRSMSX151.ger.corp.intel.com ([169.254.4.94]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 15:20:40 +0100 From: "Singh, Jasvinder" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [PATCH] app/testpmd: fix metering and policing cli command Thread-Index: AQHUVLsh2yhVX7sXskuLzkOp+0kGGaUA0S+AgAApS4CAABEKkA== Date: Tue, 25 Sep 2018 14:20:40 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D336148AB@IRSMSX103.ger.corp.intel.com> References: <20180912090202.124518-1-jasvinder.singh@intel.com> <8CEF83825BEC744B83065625E567D7C260CF336C@IRSMSX107.ger.corp.intel.com> <54CBAA185211B4429112C315DA58FF6D33614488@IRSMSX103.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260CF45F6@IRSMSX107.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CF45F6@IRSMSX107.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQ1Mzg2Y2QtNTVjMC00NzdlLTgxYTYtYWZlNTYxNTRhMjVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMkdNYVJ0cGpXZGE1NXY1TTZWRWxybjhORm9SV2J5QXQ5Q0pscnVXZWhyVUNoYm1ZZUxOeE5WQlUxZ283U3BibCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 14:20:43 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Tuesday, September 25, 2018 3:16 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command >=20 > Hi Jasvinder, >=20 > > -----Original Message----- > > From: Singh, Jasvinder > > Sent: Tuesday, September 25, 2018 12:02 PM > > To: Iremonger, Bernard ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > > > Subject: RE: [PATCH] app/testpmd: fix metering and policing cli > > command > > > > > diff --git a/app/test-pmd/cmdline_mtr.c > > b/app/test-pmd/cmdline_mtr.c > > > > index f908fb3..32a4730 100644 > > > > --- a/app/test-pmd/cmdline_mtr.c > > > > +++ b/app/test-pmd/cmdline_mtr.c > > > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_srtcm =3D { > > > > (void *)&cmd_add_port_meter_profile_srtcm_port, > > > > (void *)&cmd_add_port_meter_profile_srtcm_meter, > > > > (void *)&cmd_add_port_meter_profile_srtcm_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > > (void *)&cmd_add_port_meter_profile_srtcm_port_id, > > > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697, > > > > (void *)&cmd_add_port_meter_profile_srtcm_cir, > > > > (void *)&cmd_add_port_meter_profile_srtcm_cbs, > > > > (void *)&cmd_add_port_meter_profile_srtcm_ebs, > > > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_trtcm =3D { > > > > (void *)&cmd_add_port_meter_profile_trtcm_port, > > > > (void *)&cmd_add_port_meter_profile_trtcm_meter, > > > > (void *)&cmd_add_port_meter_profile_trtcm_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > > (void *)&cmd_add_port_meter_profile_trtcm_port_id, > > > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698, > > > > (void *)&cmd_add_port_meter_profile_trtcm_cir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_pir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_cbs, > > > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t > > > > cmd_add_port_meter_profile_trtcm_rfc4115 =3D { > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile, > > > > + (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id, > > > > (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id, > > > > - (void > > > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir, > > > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs, > > > > -- > > > > 2.9.3 > > > > > > ./devtools/check-git-log.sh -1 > > > Line too long: > > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > > 3125000000 2500000 2500000 > > > > > > > > > Also when I execute the command I get the following error: > > > > > > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000 > > > testpmd> 3125000000 > > > testpmd> 2500000 2500000 > > > cause unspecified: Function not implemented (error 1) > > > > > > Is some more configuration needed to use this command? > > > > > Meter and policing support is only available in Softnic PMD, please > > trying using that when testing the CLI. > > > > Thanks, > > Jasvinder >=20 > The fix works with the Softnic PMD. >=20 > The commit message needs revision otherwise >=20 > Acked-by: Bernard Iremonger >=20 Thanks, Bernard. Will send v2.