From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F1EA45F2D for ; Tue, 4 Dec 2018 13:28:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Dec 2018 04:28:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,314,1539673200"; d="scan'208";a="115925399" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2018 04:28:47 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.253]) by IRSMSX154.ger.corp.intel.com ([169.254.12.166]) with mapi id 14.03.0415.000; Tue, 4 Dec 2018 12:28:46 +0000 From: "Singh, Jasvinder" To: "Xu, Rosen" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Lu, Wenzhuo" , "Yigit, Ferruh" , "Wu, Jingjing" Thread-Topic: [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters Thread-Index: AQHUhWO0lo/6v8fB10O+Nn8GF+BZwqVujpLQ Date: Tue, 4 Dec 2018 12:28:46 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3366840C@IRSMSX103.ger.corp.intel.com> References: <1543221357-79801-1-git-send-email-rosen.xu@intel.com> In-Reply-To: <1543221357-79801-1-git-send-email-rosen.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODg3ODkwM2UtOGE2Yy00NTEwLWJiNzctYTczYmE4NTI1NzdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN0xsNFwva0Y0d2hvQ3pxZDQ2d2hqeXp3bSs4NXVENjYrZU9vdWlPVlFBMmgwSURpUzcrTEgrTG1aS2tua3lYMHMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 12:28:49 -0000 > -----Original Message----- > From: Xu, Rosen > Sent: Monday, November 26, 2018 8:36 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; Xu, > Rosen ; Yigit, Ferruh ; Wu, > Jingjing > Subject: [PATCH] app/test-pmd: expand test-pmd queue threshold size of RE= D > parameters >=20 > There's very commonly that more than 4G DDR memory in NIC for HQoS, so > right now the queue threshold size of RED needs to expand to uint64_t. Fo= r > struct rte_tm_red_params, it has been fixed, but for test-pmd TM > configuration, it hasn't been fixed. This patch fixes it. >=20 > Fixes: bddc2f40b594 ("app/testpmd: add commands for shaper and wred > profiles") > Cc: jasvinder.singh@intel.com >=20 > Signed-off-by: Rosen Xu > --- > app/test-pmd/cmdline_tm.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index > 4c76348..1012084 100644 > --- a/app/test-pmd/cmdline_tm.c > +++ b/app/test-pmd/cmdline_tm.c > @@ -1156,18 +1156,18 @@ struct > cmd_add_port_tm_node_wred_profile_result { > uint16_t port_id; > uint32_t wred_profile_id; > cmdline_fixed_string_t color_g; > - uint16_t min_th_g; > - uint16_t max_th_g; > + uint64_t min_th_g; > + uint64_t max_th_g; > uint16_t maxp_inv_g; > uint16_t wq_log2_g; > cmdline_fixed_string_t color_y; > - uint16_t min_th_y; > - uint16_t max_th_y; > + uint64_t min_th_y; > + uint64_t max_th_y; > uint16_t maxp_inv_y; > uint16_t wq_log2_y; > cmdline_fixed_string_t color_r; > - uint16_t min_th_r; > - uint16_t max_th_r; > + uint64_t min_th_r; > + uint64_t max_th_r; > uint16_t maxp_inv_r; > uint16_t wq_log2_r; > }; > @@ -1206,11 +1206,11 @@ struct > cmd_add_port_tm_node_wred_profile_result { cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_min_th_g =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - min_th_g, UINT16); > + min_th_g, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_max_th_g =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - max_th_g, UINT16); > + max_th_g, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_maxp_inv_g =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > @@ -1226,11 +1226,11 @@ struct > cmd_add_port_tm_node_wred_profile_result { cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_min_th_y =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - min_th_y, UINT16); > + min_th_y, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_max_th_y =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - max_th_y, UINT16); > + max_th_y, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_maxp_inv_y =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > @@ -1246,11 +1246,11 @@ struct > cmd_add_port_tm_node_wred_profile_result { cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_min_th_r =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - min_th_r, UINT16); > + min_th_r, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_max_th_r =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > - max_th_r, UINT16); > + max_th_r, UINT64); > cmdline_parse_token_num_t > cmd_add_port_tm_node_wred_profile_maxp_inv_r =3D > TOKEN_NUM_INITIALIZER( > struct cmd_add_port_tm_node_wred_profile_result, > -- Reviewed-by: Jasvinder Singh