From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5EB2E1B105 for ; Wed, 5 Dec 2018 13:22:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 04:22:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,317,1539673200"; d="scan'208";a="299515979" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga006.fm.intel.com with ESMTP; 05 Dec 2018 04:22:32 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 5 Dec 2018 12:22:31 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.253]) by irsmsx111.ger.corp.intel.com ([169.254.2.195]) with mapi id 14.03.0415.000; Wed, 5 Dec 2018 12:22:31 +0000 From: "Singh, Jasvinder" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Pattan, Reshma" Thread-Topic: [PATCH] mbuf: implement generic format for sched field Thread-Index: AQHUhXxt1GJdiKEPhUqRKZE7fTjyMKVmjkuwgAhXV4CAATlUwA== Date: Wed, 5 Dec 2018 12:22:30 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D33668DFC@IRSMSX103.ger.corp.intel.com> References: <20181123165423.134922-1-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E800A9E@IRSMSX108.ger.corp.intel.com> <54CBAA185211B4429112C315DA58FF6D33666245@IRSMSX103.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E802F9A@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E802F9A@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWNjMTgwY2YtM2RkOC00ZDljLWE3MTctYzA2OTZiODdjYjc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS2hpaXlxd3d0QXF3QUxhREFxcXNkNkdhMWwwWnpRTWczR3h1NzlMa3RkZHFlKzhJM0p3Z1hEOFd5Z2p6cG5qZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 12:22:33 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Tuesday, December 4, 2018 5:39 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Pattan, Reshma > Subject: RE: [PATCH] mbuf: implement generic format for sched field >=20 > > > > > > > + uint8_t color; /**< Color. */ > > > > > > We should create a new file rte_color.h in a common place > > > (librte_eal/common/include) to consolidate the color definition, > > > which is currently replicated in too many places, such as: > > > rte_meter.h, rte_mtr.h, rte_tm.h. > > > > > > We should include the rte_color.h file here (and in the above header > > > files) > > > > > > We should also document the link between this field and the color > > > enum > > type > > > (@see ...). > > > > Replacing the existing color definition with the above suggested one > > in rte_meter.h (librte_meter) would be ABI break. We can do it > > separately through different patch. > > > > > >=20 > We can avoid any such issues in a two step process: > 1. Create aliases to the new color in rte_meter.h, rte_mtr.h and rte_tm.h= at > this point. > 2. Announce deprecation of the existing color enums in favor of the new > unified color enum at this point and remove during next release. >=20 > Example: > //file "rte_meter.h" > #include >=20 > #define rte_meter_color rte_color > #define RTE_METER_GREEN RTE_COLOR_GREEN > #define RTE_METER_YELLOW RTE_COLOR_YELLOW #define RTE_METER_RED > RTE_COLOR_RED >=20 > Makes sense? Looks ok. We will do this clean-up work in a separate patch instead of mix= ing with mbuf patch. Thanks. =20