From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7F427F72 for ; Wed, 16 Jan 2019 11:09:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 02:09:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,485,1539673200"; d="scan'208";a="138708414" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga001.fm.intel.com with ESMTP; 16 Jan 2019 02:09:38 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.60]) by IRSMSX107.ger.corp.intel.com ([169.254.10.127]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 10:09:03 +0000 From: "Singh, Jasvinder" To: "Dumitrescu, Cristian" , "Pattan, Reshma" , Stephen Hemminger CC: "dev@dpdk.org" , "jerin.jacob@caviumnetworks.com" , "Rao, Nikhil" , "olivier.matz@6wind.com" , "thomas@monjalon.net" , "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field Thread-Index: AQHUmF3iWyO1g21bvEaNihNanOSwxqWxFPKAgACzXYCAAAQVAIAABFFw Date: Wed, 16 Jan 2019 10:09:02 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D336A1214@IRSMSX103.ger.corp.intel.com> References: <20181219154237.836-1-reshma.pattan@intel.com> <20181220121609.16314-1-reshma.pattan@intel.com> <20181220121609.16314-2-reshma.pattan@intel.com> <20190115143705.08764641@shemminger-XPS-13-9360> <3AEA2BF9852C6F48A459DA490692831F2A40107F@irsmsx110.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E82AB5F@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E82AB5F@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjUxODQzODgtYTQzNC00OWIzLWExZTgtMWY0YThmNGM2MjM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUUpuZHNYWVRHN25GSTZyeFljQWtPaGg3ckRGTTdRa1JKQ3lWT3NvNjN1aUlEM3Bidk9WKzlEZjRqaGgxTnFjYyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 10:09:41 -0000 > > > > > -----Original Message----- > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Sent: Tuesday, January 15, 2019 10:37 PM > > > To: Pattan, Reshma > > > Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Rao, Nikhil > > > ; olivier.matz@6wind.com; thomas@monjalon.net; > > > Singh, Jasvinder ; Dumitrescu, Cristian > > > ; Ananyev, Konstantin > > > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic > > > format > > for > > > sched field > > > > > > On Thu, 20 Dec 2018 12:16:09 +0000 > > > Reshma Pattan wrote: > > > > > > > This patch implements the changes proposed in the deprecation > > > > notes [1][2]. > > > > > > > > librte_mbuf changes: > > > > The mbuf->hash.sched field is updated to support generic > > > > definition in line with the ethdev traffic manager and meter APIs. > > > > The new generic format contains: queue ID, traffic class, color. > > > > > > > > Added public APIs to set and get these new fields to and from mbuf. > > > > > > > > librte_sched changes: > > > > In addtion, following API functions of the sched library have been > > > > modified with an additional parameter of type struct > > > > rte_sched_port to accommodate the changes made to mbuf sched field. > > > > (i)rte_sched_port_pkt_write() > > > > (ii) rte_sched_port_pkt_read_tree_path() > > > > > > > > librte_pipeline, qos_sched UT, qos_sched app are updated to make > > > > use of new changes. > > > > > > > > Also mbuf->hash.txadapter has been added for eventdev txq, > > > > rte_event_eth_tx_adapter_txq_set and > > > > rte_event_eth_tx_adapter_txq_get() > > > > are updated to use mbuf->hash.txadapter.txq. > > > > > > > > doc: > > > > Release notes updated. > > > > Removed deprecation notice for mbuf->hash.sched and sched API. > > > > > > > > [1] http://mails.dpdk.org/archives/dev/2018-February/090651.html > > > > [2] https://mails.dpdk.org/archives/dev/2018-November/119051.html > > > > > > > > Signed-off-by: Jasvinder Singh > > > > Signed-off-by: Reshma Pattan > > > > Acked-by: Cristian Dumitrescu > > > > Acked-by: Konstantin Ananyev > > > > > > > > > This patch breaks build of VPP because it refers to sched.hi and sche= d.lo. > > > Breaking source compatibility is as bad (if not worse) than ABI break= age. > > > > > > > Yes this breaks the build and we have actions to fix VPP Qos Sched > > when DPDK 19.02 is formally integrated to VPP. > > > > Thanks, > > Reshma >=20 > Yes, Jasvinder is the maintainer of the VPP HQoS code, this is on his pla= te to fix > in VPP for the next VPP release using DPDK release 19 Yes, patch will be up streamed as soon as dpdk19.02 is out.