From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61E89A0471 for ; Fri, 19 Jul 2019 17:25:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E6A52C2B; Fri, 19 Jul 2019 17:25:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 186A71C01 for ; Fri, 19 Jul 2019 17:25:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 08:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,282,1559545200"; d="scan'208";a="170162599" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2019 08:25:31 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.45]) by IRSMSX152.ger.corp.intel.com ([169.254.6.27]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 16:25:30 +0100 From: "Singh, Jasvinder" To: "Dumitrescu, Cristian" , "dev@dpdk.org" CC: "Tovar, AbrahamX" , "Krakowiak, LukaszX" Thread-Topic: [PATCH v5 06/11] sched: improve doxygen comments Thread-Index: AQHVPb4+hsWCG4CyLE+Bl0AaO08UCabSEEnA Date: Fri, 19 Jul 2019 15:25:29 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3FD992CA@IRSMSX103.ger.corp.intel.com> References: <20190712095729.159767-2-jasvinder.singh@intel.com> <20190717144245.138876-1-jasvinder.singh@intel.com> <20190717144245.138876-7-jasvinder.singh@intel.com> <3EB4FA525960D640B5BDFFD6A3D891268E8F03D5@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E8F03D5@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTdkNjQxMjktNmI2MS00ZGMzLTliMDMtOGMyMThhZDdhYjA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicU5sb0lvWDZ0anh1dTh0eUVtMEZpdExaXC8rOElZOThQdlBWdUI5eFBmMlwvOGd3Sm9FaFFXZkZ2azdDT1wvdlFaQiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 06/11] sched: improve doxygen comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > @@ -165,61 +170,90 @@ struct rte_sched_subport_stats { > > * byte. > > */ > > struct rte_sched_pipe_params { > > - /* Pipe token bucket */ > > - uint32_t tb_rate; /**< Rate (measured in bytes per sec= ond) > > */ > > - uint32_t tb_size; /**< Size (measured in credits) */ > > + /** Token bucket rate (measured in bytes per second) */ > > + uint32_t tb_rate; > > > > - /* Pipe traffic classes */ > > + /** Token bucket size (measured in credits) */ > > + uint32_t tb_size; > > + > > + /** Traffic class rates (measured in bytes per second) */ > > uint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; > > - /**< Traffic class rates (measured in bytes per second) */ > > + > > + /** Enforcement period (measured in milliseconds) */ > > uint32_t tc_period; > > - /**< Enforcement period (measured in milliseconds) */ > > - uint8_t tc_ov_weight; /**< Weight Traffic class 3 > > oversubscription */ > > > > - /* Pipe queues */ > > - uint8_t wrr_weights[RTE_SCHED_BE_QUEUES_PER_PIPE]; /**< > > WRR weights */ > > + /** Best-effort traffic class oversubscription weight */ > > + uint8_t tc_ov_weight; > > + > > + /** WRR weights of best-effort traffic class queues */ > > + uint8_t wrr_weights[RTE_SCHED_BE_QUEUES_PER_PIPE]; > > }; > > > > /** Queue statistics */ > > struct rte_sched_queue_stats { > > - /* Packets */ > > - uint32_t n_pkts; /**< Packets successfully written */ > > - uint32_t n_pkts_dropped; /**< Packets dropped */ > > + /** Packets successfully written */ > > + uint32_t n_pkts; > > + > > + /** Packets dropped */ > > + uint32_t n_pkts_dropped; > > + > > #ifdef RTE_SCHED_RED > > - uint32_t n_pkts_red_dropped; /**< Packets dropped by RED */ > > + /** Packets dropped by RED */ > > + uint32_t n_pkts_red_dropped; > > #endif > > > > - /* Bytes */ > > - uint32_t n_bytes; /**< Bytes successfully written */ > > - uint32_t n_bytes_dropped; /**< Bytes dropped */ > > + /** Bytes successfully written */ > > + uint32_t n_bytes; > > + > > + /** Bytes dropped */ > > + uint32_t n_bytes_dropped; > > }; > > > > /** Port configuration parameters. */ struct rte_sched_port_params { > > - const char *name; /**< String to be associated */ > > - int socket; /**< CPU socket ID */ > > - uint32_t rate; /**< Output port rate > > - * (measured in bytes per second) */ > > - uint32_t mtu; /**< Maximum Ethernet frame size > > - * (measured in bytes). > > - * Should not include the framing > > overhead. */ > > - uint32_t frame_overhead; /**< Framing overhead per packet > > - * (measured in bytes) */ > > - uint32_t n_subports_per_port; /**< Number of subports */ > > - uint32_t n_pipes_per_subport; /**< Number of pipes per subport > > */ > > + /** Name of the port to be associated */ > > + const char *name; > > + > > + /** CPU socket ID */ > > + int socket; > > + > > + /** Output port rate (measured in bytes per second) */ > > + uint32_t rate; > > + > > + /** Maximum Ethernet frame size (measured in bytes). > > + * Should not include the framing overhead. > > + */ > > + uint32_t mtu; > > + > > + /** Framing overhead per packet (measured in bytes) */ > > + uint32_t frame_overhead; > > + > > + /** Number of subports */ > > + uint32_t n_subports_per_port; > > + > > + /** Number of subport_pipes */ > > + uint32_t n_pipes_per_subport; > > + > > + /** Packet queue size for each traffic class. > > + * All the pipes within the same subport share the similar > > + * configuration for the queues. > > + */ > > uint16_t qsize[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; > > - /**< Packet queue size for each traffic class. > > - * All queues within the same pipe traffic class have the same > > - * size. Queues from different pipes serving the same traffic > > - * class have the same size. */ > > + > > + /** Pipe profile table. > > + * Every pipe is configured using one of the profiles from this table= . > > + */ > > struct rte_sched_pipe_params *pipe_profiles; > > - /**< Pipe profile table. > > - * Every pipe is configured using one of the profiles from this table= . > > */ > > - uint32_t n_pipe_profiles; /**< Profiles in the pipe profile ta= ble */ > > + > > + /** Profiles in the pipe profile table */ > > + uint32_t n_pipe_profiles; > > + > > + /** Max profiles allowed in the pipe profile table */ > > uint32_t n_max_pipe_profiles; > > - /**< Max profiles allowed in the pipe profile table */ > > + > > #ifdef RTE_SCHED_RED > > - struct rte_red_params > > red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS]; /**< > RED > > parameters */ > > + /** RED parameters */ > > + struct rte_red_params > > red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS]; > > #endif > > }; > > > > @@ -333,8 +367,8 @@ rte_sched_port_get_memory_footprint(struct > > rte_sched_port_params *params); > > * Pointer to pre-allocated subport statistics structure where the s= tatistics > > * counters should be stored > > * @param tc_ov > > - * Pointer to pre-allocated 4-entry array where the oversubscription= status > > for > > - * each of the 4 subport traffic classes should be stored. > > + * Pointer to pre-allocated 13-entry array where the oversubscriptio= n >=20 > Please replace "13" by RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE. Done in v6. > I also suggest moving the definition of RTE_SCHED_TRAFFIC_CLASS_BE to thi= s > file. Done in v6. > > status for > > + * each of the subport traffic classes should be stored. > > * @return > > * 0 upon success, error code otherwise > > */ > > @@ -379,9 +413,10 @@ rte_sched_queue_read_stats(struct rte_sched_port > > *port, > > * @param pipe > > * Pipe ID within subport > > * @param traffic_class > > - * Traffic class ID within pipe (0 .. 3) > > + * Traffic class ID within pipe (0 .. RTE_SCHED_TRAFFIC_CLASSES_PER_= PIPE > > - 1) > > * @param queue > > - * Queue ID within pipe traffic class (0 .. 3) > > + * Queue ID within pipe traffic class, 0 for high priority TCs, and > > + * 0 .. (RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE-1) for best-effort TC >=20 > This should be: 0 .. (RTE_SCHED_BE_QUEUES_PER_PIPE - 1) for the Best Effo= rt > traffic class. Fixed in v6, thanks. >=20 > > * @param color > > * Packet color set > > */ > > @@ -406,10 +441,10 @@ rte_sched_port_pkt_write(struct rte_sched_port > > *port, > > * @param pipe > > * Pipe ID within subport > > * @param traffic_class > > - * Traffic class ID within pipe (0 .. 3) > > + * Traffic class ID within pipe (0 .. > > RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE-1) > > * @param queue > > - * Queue ID within pipe traffic class (0 .. 3) > > - * > > + * Queue ID within pipe traffic class, 0 for high priority TCs, and > > + * 0 .. (RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE-1) for best-effort TC >=20 > This should be: 0 .. (RTE_SCHED_BE_QUEUES_PER_PIPE - 1) for the Best Effo= rt > traffic class. Fixed in v6. =20 > > */ > > void > > rte_sched_port_pkt_read_tree_path(struct rte_sched_port *port, > > -- > > 2.21.0