From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83292A0471 for ; Mon, 9 Sep 2019 09:01:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F6AA1EA1E; Mon, 9 Sep 2019 09:01:37 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CB47F1EA1A for ; Mon, 9 Sep 2019 09:01:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 00:01:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,484,1559545200"; d="scan'208";a="384864634" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga006.fm.intel.com with ESMTP; 09 Sep 2019 00:01:33 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.36]) by IRSMSX153.ger.corp.intel.com ([169.254.9.123]) with mapi id 14.03.0439.000; Mon, 9 Sep 2019 08:01:33 +0100 From: "Singh, Jasvinder" To: Andrew Rybchenko , "Dumitrescu, Cristian" CC: "dev@dpdk.org" , Ivan Ilchenko Thread-Topic: [PATCH v2 16/54] net/softnic: check status of getting ethdev info Thread-Index: AQHVYl+ZPDDPfV5bpkOtJbTbSnjruqci88oA Date: Mon, 9 Sep 2019 07:01:32 +0000 Message-ID: <54CBAA185211B4429112C315DA58FF6D3FDF5FC6@IRSMSX103.ger.corp.intel.com> References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> <1567519051-28189-1-git-send-email-arybchenko@solarflare.com> <1567519051-28189-17-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1567519051-28189-17-git-send-email-arybchenko@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzc4NTZkM2ItNjIxZS00NzU0LThiMzAtZjQxODM0NGJjOWU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicURDOWJaNWJ0NG1zMGJ5NVRCem9XRzgxYzZKSVl6UXZZUnJ0NU92Wnk0bEdTekhZUUxMaG1LNkx4XC9yQWNsMXcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 16/54] net/softnic: check status of getting ethdev info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Andrew Rybchenko [mailto:arybchenko@solarflare.com] > Sent: Tuesday, September 3, 2019 2:57 PM > To: Singh, Jasvinder ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: [PATCH v2 16/54] net/softnic: check status of getting ethdev inf= o >=20 > From: Ivan Ilchenko >=20 > rte_eth_dev_info_get() return value was changed from void to int, so this > patch modify rte_eth_dev_info_get() usage across net/softnic according to= its > new return type. >=20 > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > --- > drivers/net/softnic/rte_eth_softnic_link.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_link.c > b/drivers/net/softnic/rte_eth_softnic_link.c > index d669913..21a6406 100644 > --- a/drivers/net/softnic/rte_eth_softnic_link.c > +++ b/drivers/net/softnic/rte_eth_softnic_link.c > @@ -57,6 +57,7 @@ struct softnic_link * > struct rte_eth_dev_info port_info; > struct softnic_link *link; > uint16_t port_id; > + int ret; >=20 > /* Check input params */ > if (name =3D=3D NULL || > @@ -78,7 +79,9 @@ struct softnic_link * > return NULL; > } >=20 > - rte_eth_dev_info_get(port_id, &port_info); > + ret =3D rte_eth_dev_info_get(port_id, &port_info); > + if (ret !=3D 0) > + return NULL; >=20 > /* Node allocation */ > link =3D calloc(1, sizeof(struct softnic_link)); > -- > 1.8.3.1 Acked-by: Jasvinder Singh