DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
@ 2016-03-31 13:29 Fan Zhang
  2016-04-05 15:45 ` Thomas Monjalon
  2016-04-05 21:16 ` Singh, Jasvinder
  0 siblings, 2 replies; 7+ messages in thread
From: Fan Zhang @ 2016-03-31 13:29 UTC (permalink / raw)
  To: dev

Several new fields will be added to structure rte_port_source_params for
source port enhancement with pcap file reading support.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 179e30f..9b4fc9d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -25,3 +25,8 @@ Deprecation Notices
 * ABI changes are planned for adding four new flow types. This impacts
   RTE_ETH_FLOW_MAX. The release 2.2 does not contain these ABI changes,
   but release 2.3 will. [postponed]
+
+* ABI changes are planned for struct rte_port_source_params in order to
+  support PCAP file reading feature. The release 16.04 contains this ABI
+  change wrapped by RTE_NEXT_ABI macro. Release 16.07 will contain this
+  change, and no backwards compatibility is planned.
-- 
2.5.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
  2016-03-31 13:29 [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure Fan Zhang
@ 2016-04-05 15:45 ` Thomas Monjalon
  2016-04-05 21:16 ` Singh, Jasvinder
  1 sibling, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2016-04-05 15:45 UTC (permalink / raw)
  To: dev; +Cc: Fan Zhang

2016-03-31 14:29, Fan Zhang:
> Several new fields will be added to structure rte_port_source_params for
> source port enhancement with pcap file reading support.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Anyone interested or against this ABI break in rte_port?
It will be accepted when having 3 acks without any nack.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
  2016-03-31 13:29 [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure Fan Zhang
  2016-04-05 15:45 ` Thomas Monjalon
@ 2016-04-05 21:16 ` Singh, Jasvinder
  2016-04-06  8:51   ` Azarewicz, PiotrX T
  1 sibling, 1 reply; 7+ messages in thread
From: Singh, Jasvinder @ 2016-04-05 21:16 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Thursday, March 31, 2016 2:29 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for
> rte_port_source_params structure
> 
> Several new fields will be added to structure rte_port_source_params for
> source port enhancement with pcap file reading support.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
  2016-04-05 21:16 ` Singh, Jasvinder
@ 2016-04-06  8:51   ` Azarewicz, PiotrX T
  2016-04-07 21:24     ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: Azarewicz, PiotrX T @ 2016-04-06  8:51 UTC (permalink / raw)
  To: Singh, Jasvinder, Zhang, Roy Fan, dev

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> > Sent: Thursday, March 31, 2016 2:29 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] doc: announce ABI change for
> > rte_port_source_params structure
> >
> > Several new fields will be added to structure rte_port_source_params
> > for source port enhancement with pcap file reading support.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

Acked-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
  2016-04-06  8:51   ` Azarewicz, PiotrX T
@ 2016-04-07 21:24     ` Thomas Monjalon
  2016-04-12 12:39       ` Thomas Monjalon
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2016-04-07 21:24 UTC (permalink / raw)
  To: Zhang, Roy Fan; +Cc: dev, Azarewicz, PiotrX T, Singh, Jasvinder

> > > Several new fields will be added to structure rte_port_source_params
> > > for source port enhancement with pcap file reading support.
> > >
> > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> 
> Acked-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>

Applied, thanks

Please send a patch to remove NEXT_ABI early in the 16.07 cycle.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
  2016-04-07 21:24     ` Thomas Monjalon
@ 2016-04-12 12:39       ` Thomas Monjalon
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2016-04-12 12:39 UTC (permalink / raw)
  To: Zhang, Roy Fan; +Cc: dev, Azarewicz, PiotrX T, Singh, Jasvinder

Hi Fan Zhang,

2016-04-07 23:24, Thomas Monjalon:
> Please send a patch to remove NEXT_ABI early in the 16.07 cycle.

Please could you prepare a patch to remove NEXT_ABI from rte_port?
Thanks

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure
@ 2016-03-31 13:28 Fan Zhang
  0 siblings, 0 replies; 7+ messages in thread
From: Fan Zhang @ 2016-03-31 13:28 UTC (permalink / raw)
  To: dev

Several new fields will be added to structure rte_port_source_params for
source port enhancement with pcap file reading support.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 179e30f..9b4fc9d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -25,3 +25,8 @@ Deprecation Notices
 * ABI changes are planned for adding four new flow types. This impacts
   RTE_ETH_FLOW_MAX. The release 2.2 does not contain these ABI changes,
   but release 2.3 will. [postponed]
+
+* ABI changes are planned for struct rte_port_source_params in order to
+  support PCAP file reading feature. The release 16.04 contains this ABI
+  change wrapped by RTE_NEXT_ABI macro. Release 16.07 will contain this
+  change, and no backwards compatibility is planned.
-- 
2.5.0

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-04-12 12:39 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-31 13:29 [dpdk-dev] [PATCH] doc: announce ABI change for rte_port_source_params structure Fan Zhang
2016-04-05 15:45 ` Thomas Monjalon
2016-04-05 21:16 ` Singh, Jasvinder
2016-04-06  8:51   ` Azarewicz, PiotrX T
2016-04-07 21:24     ` Thomas Monjalon
2016-04-12 12:39       ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2016-03-31 13:28 Fan Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).