DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
@ 2016-06-16  9:04 Jasvinder Singh
  2016-06-21 20:49 ` Thomas Monjalon
  2016-06-22  9:01 ` Singh, Jasvinder
  0 siblings, 2 replies; 4+ messages in thread
From: Jasvinder Singh @ 2016-06-16  9:04 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu

Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro
in TM (Traffic Manager) port section parsing function. This macro adds
nic ports entry specified in TM port section of the application
configuration file to the application parameters structure.

Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/ip_pipeline/config_parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/config_parse.c b/examples/ip_pipeline/config_parse.c
index 504018e..5e70d78 100644
--- a/examples/ip_pipeline/config_parse.c
+++ b/examples/ip_pipeline/config_parse.c
@@ -1816,7 +1816,7 @@ parse_tm(struct app_params *app,
 	param = &app->tm_params[param_idx];
 	PARSE_CHECK_DUPLICATE_SECTION(param);
 
-	APP_PARAM_ADD_LINK_FOR_TXQ(app, section_name);
+	APP_PARAM_ADD_LINK_FOR_TM(app, section_name);
 
 	for (i = 0; i < n_entries; i++) {
 		struct rte_cfgfile_entry *ent = &entries[i];
-- 
2.5.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
  2016-06-16  9:04 [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section Jasvinder Singh
@ 2016-06-21 20:49 ` Thomas Monjalon
  2016-06-21 23:28   ` Dumitrescu, Cristian
  2016-06-22  9:01 ` Singh, Jasvinder
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-06-21 20:49 UTC (permalink / raw)
  To: cristian.dumitrescu; +Cc: dev, Jasvinder Singh

2016-06-16 10:04, Jasvinder Singh:
> Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro
> in TM (Traffic Manager) port section parsing function. This macro adds
> nic ports entry specified in TM port section of the application
> configuration file to the application parameters structure.
> 
> Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI")

Cristian, you should not ack a patch which do more than announced in
the title. This pipeline KNI patch do a lot of things without any
explanation for the fixes.
1 explanation = 1 patch

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
  2016-06-21 20:49 ` Thomas Monjalon
@ 2016-06-21 23:28   ` Dumitrescu, Cristian
  0 siblings, 0 replies; 4+ messages in thread
From: Dumitrescu, Cristian @ 2016-06-21 23:28 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Singh, Jasvinder



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, June 21, 2016 9:49 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port
> section
> 
> 2016-06-16 10:04, Jasvinder Singh:
> > Replace APP_PARAM_ADD_LINK_FOR_TXQ with
> APP_PARAM_ADD_LINK_FOR_TM macro
> > in TM (Traffic Manager) port section parsing function. This macro adds
> > nic ports entry specified in TM port section of the application
> > configuration file to the application parameters structure.
> >
> > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration
> parser")
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI")
> 
> Cristian, you should not ack a patch which do more than announced in
> the title. This pipeline KNI patch do a lot of things without any
> explanation for the fixes.
> 1 explanation = 1 patch

Yeah, there were several small issues to fix and several people spotted them at the same time. I agree we should do a better job at separating different fixes into different patches. Sorry about this.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
  2016-06-16  9:04 [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section Jasvinder Singh
  2016-06-21 20:49 ` Thomas Monjalon
@ 2016-06-22  9:01 ` Singh, Jasvinder
  1 sibling, 0 replies; 4+ messages in thread
From: Singh, Jasvinder @ 2016-06-22  9:01 UTC (permalink / raw)
  To: Singh, Jasvinder, dev; +Cc: Dumitrescu, Cristian



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Thursday, June 16, 2016 10:05 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section
> 
> Replace APP_PARAM_ADD_LINK_FOR_TXQ with
> APP_PARAM_ADD_LINK_FOR_TM macro in TM (Traffic Manager) port
> section parsing function. This macro adds nic ports entry specified in TM port
> section of the application configuration file to the application parameters
> structure.
> 
> Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>  examples/ip_pipeline/config_parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/ip_pipeline/config_parse.c
> b/examples/ip_pipeline/config_parse.c
> index 504018e..5e70d78 100644

Self-NACK ;  fix applied by another patch.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-06-22  9:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16  9:04 [dpdk-dev] [PATCH] ip_pipeline: fix parsing error in TM port section Jasvinder Singh
2016-06-21 20:49 ` Thomas Monjalon
2016-06-21 23:28   ` Dumitrescu, Cristian
2016-06-22  9:01 ` Singh, Jasvinder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).