From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by dpdk.org (Postfix) with ESMTP id 044515A81 for ; Sun, 1 Feb 2015 05:04:05 +0100 (CET) Received: by mail-pa0-f47.google.com with SMTP id lj1so68289773pab.6 for ; Sat, 31 Jan 2015 20:04:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=xvKzDpJQ98xkgNWIIgthXKoeXn+7HVHrcIt6SvwPzVw=; b=CLWmZdGArBarSP02b0xf5ayryPHYDHGw4pTG7OZm9FywlOPgNeQ0nWZYLUTYS5qHTn xMFq/DoqHGiD5zNSNcNVFG2KwHDvPR0CEDK5lppfXBdyYQBQEWf7iabaXcrpeoac0W/J RQCngQSOv3UEY0kkdQi11DoiyRtpXMv/aUTGEA3niO9IBj06+QsNFYV4wh4s+TimK0Cg Ue08NAiFTN/ccIdOffPJuPfDT5wRyXNkfGtwxpCuqGgtybF3R5O2T4HX/nByt4Ah+cIj S34uhzzIGlhL44+wss0Hu2goEEcADXEi0N+Gdu6Gyym5t5InF3uxxcsti2qHulzqQFWU F6Zw== X-Gm-Message-State: ALoCoQm1BGNnfx45Kg8vb7OvSmnu5e4lU+mhZq9z4hZbpVxdl6xFMGgT5kbMP8Y9TCIadMUfG0QO X-Received: by 10.68.195.65 with SMTP id ic1mr19765101pbc.109.1422763444383; Sat, 31 Jan 2015 20:04:04 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id pp9sm14929651pbb.65.2015.01.31.20.04.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Jan 2015 20:04:03 -0800 (PST) Message-ID: <54CDA5B2.70001@igel.co.jp> Date: Sun, 01 Feb 2015 13:04:02 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Xie, Huawei" , "dev@dpdk.org" References: <1422599787-12009-1-git-send-email-huawei.xie@intel.com> <1422599787-12009-6-git-send-email-huawei.xie@intel.com> <54CB572B.4040409@igel.co.jp> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/12] lib/librte_vhost: copy host_memory_map from virtio-net.c to a new file virtio-net-cdev.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Feb 2015 04:04:05 -0000 On 2015/02/01 0:16, Xie, Huawei wrote: >>> + * map it to our address space. >>> + */ >>> +static int >>> +host_memory_map(struct virtio_net *dev, struct virtio_memory *mem, >>> + pid_t pid, uint64_t addr) >>> +{ >> Hi Xie, >> >> This patch only copy host_memory_map() to a new file. >> And actually the original function is removed at below patch. >> - "[PATCH 07/12] lib/librte_vhost: split set_memory_table into two parts" >> >> Is it difficult to remove and copy the function in this patch? > The purpose of splitting into several patches is to be reviewer friendly. > You could easily check the changes between each commit. OK, Thanks. Tetsuya >> Thanks, >> Tetsuya >>