From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id F3A22379B for ; Tue, 3 Feb 2015 02:32:17 +0100 (CET) Received: by mail-pa0-f53.google.com with SMTP id kx10so89381496pab.12 for ; Mon, 02 Feb 2015 17:32:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=3HvHCpKZBM78C4Ou+GhM3wVbg5Lji/cYHcIBAX9tem4=; b=l/D03F63kWU/ecV50OdEF0373dGcPBNcgDH4r4up6zNrTMPcAep8UJ+RyevuRFN92G vny4KFRjnTsx4cNPpJbtxSMOHSo26nWan26B4pt3fPtsPBmJbkZuurz9u/tM+oHIEiKx TnLGIF/Q256GornCyZm2pbik1VZPOn5qtlhfT5RXRr8lGuDytFUAjdD8qh5UKKVXWzl6 7i1CBmuLsbBqZh5qsr4FQw98MiaVQmF6ZSgBUgEd2/DDzsFAWMdb6/NP6oS16cEuSeNO tJlm1ijJSm6A+zOoMo+2R/zBULwizYu9h8uKBH/EOSaShYz8qiyXYj3wPVrt25y5V6cB 5E0w== X-Gm-Message-State: ALoCoQkRHS/mvCJfDzdntP+M7hA3Hzk8ELIT1io/G4iRKuH6xUE2x6AL0NaUBBiBXfV+roQsmOQb X-Received: by 10.70.140.44 with SMTP id rd12mr34038978pdb.64.1422927137229; Mon, 02 Feb 2015 17:32:17 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id a10sm307827pdl.61.2015.02.02.17.32.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Feb 2015 17:32:16 -0800 (PST) Message-ID: <54D0251C.2050407@igel.co.jp> Date: Tue, 03 Feb 2015 10:32:12 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp> <1422763322-13742-1-git-send-email-mukawa@igel.co.jp> <1422763322-13742-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] testpmd: Add port hotplug support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 01:32:18 -0000 On 2015/02/02 20:33, Iremonger, Bernard wrote >> /* >> * Work-around of a compilation error with ICC on invocations of the >> * rte_be_to_cpu_16() function. >> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> index 218835a..1cacbcf 100644 >> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > Hi Tetsuya, > > The doc changes should be in separate commit using the "doc: explaination" commit line. > >> @@ -808,6 +808,63 @@ The following sections show functions for configuring ports. >> >> Port configuration changes only become active when forwarding is started/restarted. >> >> +port attach >> +~~~~~~~~~~~ >> + >> +Attach a port specified by pci address or virtual device args. >> + >> +To attach a new pci device, the device should be recognized by kernel first. >> +Then it should be moved under DPDK management. >> +Finally the port can be attached to testpmd. >> +On the other hand, to attach a port created by virtual device, above steps are not needed. >> + >> +port attach (identifier) >> + >> +For example, to attach a port that pci address is 0000:02:00.0. > Reword " port that pci address is " to "port whose pci address is" Hi Bernard, Thanks, I will fix below comments like your suggestion. Tetsuya >> + >> +.. code-block:: console >> + >> + testpmd> port attach 0000:02:00.0 >> + Attaching a new port... >> + ... snip ... >> + Port 0 is attached. Now total ports is 1 >> + Done >> + >> +For example, to attach a port created by pcap PMD. >> + >> +.. code-block:: console >> + >> + testpmd> port attach eth_pcap0,iface=eth0 >> + Attaching a new port... >> + ... snip ... >> + Port 0 is attached. Now total ports is 1 >> + Done >> + >> +In this case, identifier is "eth_pcap0,iface=eth0". >> +This identifier format is the same as "--vdev" format of DPDK applications. >> + >> +port detach >> +~~~~~~~~~~~ >> + >> +Detach a specific port. >> + >> +Before detaching a port, the port should be closed. >> +Also to remove a pci device completely from the system, first detach the port from testpmd. >> +Then the device should be moved under kernel management. >> +Finally the device can be remove using kernel pci hotplug functionality. > Reword "remove" to "removed" > >> +On the other hand, to remove a port created by virtual device, above steps are not needed. > Reword " created by virtual device" to "created by a virtual device" > >> + >> +port detach (port_id) >> + >> +For example, to detach a port 0. >> + >> +.. code-block:: console >> + >> + testpmd> port detach 0 >> + Detaching a port... >> + ... snip ... >> + Done >> + >> port start >> ~~~~~~~~~~ >> >> -- >> 1.9.1 > Regards, > > Bernard. >