From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com [209.85.218.52]) by dpdk.org (Postfix) with ESMTP id EECFD37AA for ; Tue, 3 Feb 2015 02:34:25 +0100 (CET) Received: by mail-oi0-f52.google.com with SMTP id h136so47025331oig.11 for ; Mon, 02 Feb 2015 17:34:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4Jl2pWJUiGHJ8e2RM4eCrZ3ZNoOTmo4nAi3iDHBp0KY=; b=YssoI6h2JNPNQpAeSva/HfK+dwbmF1qBTG3UW+MJjFFCwPTDrokEDZdq4yudv5ROwg 70Gh/aHRV3rKoC/xeez3pAZYZzcLlmbf+1xHLuS43HCRdaPQlthzmGLGZBisaZuAIt54 M6MnxNHTZnqabnspzUF/tqZT6+ZCPiX9cB3y5Lp6nfscN5Bkt4fCOWj0XOhTaGbJhc57 Br1WzbxolSCDcUAwAqFufsB6umGxVtEPn7Np3vdJU22u63MpYnAv+/4W8qHESA6znsbX gW0HwYylOhVdrete36bXXFwrGFrT6WGHtHFksrIapD3EBI23PjF5c33Hgs0WruMNX2Ql 33dQ== X-Gm-Message-State: ALoCoQmSG2pC6z+qIZaU8/yimV03wJqUxo04HQ4oiRhUzq2kSRkKw1yDSintsNYzplMTHOp3Belg X-Received: by 10.68.237.106 with SMTP id vb10mr511875pbc.59.1422927265406; Mon, 02 Feb 2015 17:34:25 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id f12sm306703pat.43.2015.02.02.17.34.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Feb 2015 17:34:24 -0800 (PST) Message-ID: <54D0259D.6020205@igel.co.jp> Date: Tue, 03 Feb 2015 10:34:21 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Monjalon , "Iremonger, Bernard" References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp> <1422763322-13742-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> <1688512.MY7Nexz1BF@xps13> In-Reply-To: <1688512.MY7Nexz1BF@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6] testpmd: Add port hotplug support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 01:34:26 -0000 On 2015/02/02 20:57, Thomas Monjalon wrote: > 2015-02-02 11:33, Iremonger, Bernard: >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >> Hi Tetsuya, >> >> The doc changes should be in separate commit using the "doc: explaination" commit line. > I agree that new docs should be in a separate commit. > Though when updating some code (like here), it's a good idea to update the doc > in the same commit. Then the change is atomic. > > If you want to figure which patches are updating the doc, it should be possible > to have a filter on "+++ b/doc/". > Hi Thomas, I appreciate your comment. I will follow this guideline. Thanks, Tetsuya