From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 63C799AB5 for ; Tue, 3 Feb 2015 11:31:12 +0100 (CET) Received: by mail-pa0-f46.google.com with SMTP id lj1so94652986pab.5 for ; Tue, 03 Feb 2015 02:31:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=YWQNl5XyV9LU+eaFh4TDVwoFsDCGRa/sHOE/IYhk1cs=; b=IX4x8Tpwb6OwARjhnJkPPyQhdEN/NNMwb0GWSZ804GrZ9XQpBcik/PRfRIJw/h2JgS LxqycycwCxtEAAvt9ofFbjUcwMIW/HfJUJLJlGfQISpr2TqetiS7Yp/5eJQEuR5YNRJF igxC3HfojPiVPtIb+VrAqCjHutJ8zFEcSFMlIRG4jB62fb6yhuCkhhGioTs9GG7EhwN7 XMTMNdY5FNCIqT9cCfAwysWtJ70ryqQ4ioEyvcAMGWhy8Xe5kX53bCL5bv6616X4+6dR nGADdqHDp6V6f2lmYGqM+YcMBSfe1Q5H//hZLMuFmILUryy0PogdHU4ZZsU2y718+/Gf pnLA== X-Gm-Message-State: ALoCoQmXP5Jo5gn8qGdHFi15EupTBfGOD5mZ9SbUbi79k9dWWU8FrB7MUA0qLB7j3UOeTexUDSgA X-Received: by 10.70.125.232 with SMTP id mt8mr22002437pdb.152.1422959471754; Tue, 03 Feb 2015 02:31:11 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id nw6sm1697253pbb.94.2015.02.03.02.31.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Feb 2015 02:31:11 -0800 (PST) Message-ID: <54D0A36B.6030306@igel.co.jp> Date: Tue, 03 Feb 2015 19:31:07 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp> <1422763322-13742-1-git-send-email-mukawa@igel.co.jp> <1422763322-13742-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com> <54D0251C.2050407@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DCF56@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DCF56@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] testpmd: Add port hotplug support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 10:31:12 -0000 Hi Bernard, I appreciate your checking. I will fix like below. Tetsuya On 2015/02/03 19:03, Iremonger, Bernard wrote: >>>> +.. code-block:: console >>>> + >>>> + testpmd> port attach 0000:02:00.0 >>>> + Attaching a new port... >>>> + ... snip ... >>>> + Port 0 is attached. Now total ports is 1 >>>> + Done >>>> +port detach >>>> +~~~~~~~~~~~ >>>> + >>>> +Detach a specific port. >>>> + >>>> +Before detaching a port, the port should be closed. >>>> +Also to remove a pci device completely from the system, first detach the port from testpmd. >>>> +Then the device should be moved under kernel management. >>>> +Finally the device can be remove using kernel pci hotplug functionality. > Hi Tetsuya, > Reword "remove" to "removed" > >>>> +On the other hand, to remove a port created by virtual device, above steps are not needed. > Reword " created by virtual device" to "created by a virtual device" > >>>> + >>>> +port detach (port_id) >>>> + >>>> +For example, to detach a port 0. >>>> + >>>> +.. code-block:: console >>>> + >>>> + testpmd> port detach 0 >>>> + Detaching a port... >>>> + ... snip ... >>>> + Done >>>> + >>>> port start >>>> ~~~~~~~~~~ >>>> >>>> -- >>>> 1.9.1 >>> Regards, >>> >>> Bernard. >>>