From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id D2AB6B468 for ; Thu, 5 Feb 2015 10:58:41 +0100 (CET) Received: by mail-wi0-f180.google.com with SMTP id h11so9323177wiw.1 for ; Thu, 05 Feb 2015 01:58:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=70KYPPlL6wj6oHxecfNDkwGRPZ5Mkelz2Q7PBArcvYU=; b=jWI7bLENmPsZjjB387wuzTIFYed+cZBR147cOgiCHbGfpQ2HUAdN8p6uHhkFa+fYak tToiWMi+jZ9DDQdOGgLIePqVNFbxhmU+IfMOqe7RFEnqyXSG8tFoPylLqylZ3VYia3P6 nVbS6iUVYXspOKnZBRP6u+IhJlVeUq6ySNZfhqUIC3jINbl8mT2yIxPxn9sMNg4nLLNP xPr0u+M+uSIg9LTJz6Dq6R8692hyyMvuRvqrocqvZOGZCHgav+dKA9pxdhAzNftmFXD3 /G8NEuQELLiw1zJJgwnHrALKEu25T47B/lRCtAi4IB1sklYG+cqR1c/x/Vk0SJMjW4kU qkOA== X-Gm-Message-State: ALoCoQlQsVXMlTjBr3geLeH4PBeX0e1bFyZZI/FOGnsiTHJ9dQPOm5LUlegIlIULvqdioQKCzm/7 X-Received: by 10.194.61.12 with SMTP id l12mr5549645wjr.139.1423130321703; Thu, 05 Feb 2015 01:58:41 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id g10sm33111440wic.7.2015.02.05.01.58.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 01:58:40 -0800 (PST) Message-ID: <54D33ED0.1030603@6wind.com> Date: Thu, 05 Feb 2015 10:58:40 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Xuelin Shi , "dev@dpdk.org" References: <1422859901-3896-1-git-send-email-xuelin.shi@freescale.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] fix testpmd show port info error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Feb 2015 09:58:42 -0000 Hi, On 02/05/2015 10:26 AM, Xuelin Shi wrote: > Hi, > > Anybody interested in this patch could have a review or comment on it? > I'm new here. Should I send this patch to some specific maintainer to make this more efficient? > > Thanks, > Shi Xuelin > > -----Original Message----- > From: xuelin.shi@freescale.com [mailto:xuelin.shi@freescale.com] > Sent: Monday, February 02, 2015 14:52 > To: dev@dpdk.org > Cc: Shi Xuelin-B29237 > Subject: [PATCH] fix testpmd show port info error > > From: Xuelin Shi > > the port number type should be consistent with librte_cmdline, else there is potential endian issue. > > Signed-off-by: Xuelin Shi > --- > app/test-pmd/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4beb404..488ac63 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -5568,7 +5568,7 @@ cmdline_parse_token_string_t cmd_showport_what = > TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what, > "info#stats#xstats#fdir#stat_qmap"); > cmdline_parse_token_num_t cmd_showport_portnum = > - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32); > + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT8); > > cmdline_parse_inst_t cmd_showport = { > .f = cmd_showport_parsed, > -- Thank you for reporting this. However I think it should be UINT8 instead of INT8. According to http://dpdk.org/dev, I think a better title could be "testpmd: fix port parsing in show port info command" Apart from this, Acked-by: Olivier Matz I think it would be less work for Thomas if you can submit a v2 that includes these 2 changes. Regards, Olivier