From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 24C9D234 for ; Fri, 6 Feb 2015 09:30:56 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YJeN3-0003Sw-AU; Fri, 06 Feb 2015 09:34:41 +0100 Message-ID: <54D47BB4.9020005@6wind.com> Date: Fri, 06 Feb 2015 09:30:44 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: xuelin.shi@freescale.com References: <1423186160-26035-1-git-send-email-xuelin.shi@freescale.com> In-Reply-To: <1423186160-26035-1-git-send-email-xuelin.shi@freescale.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] testpmd: fix port parsing in show port info command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 08:30:56 -0000 Hi, On 02/06/2015 02:29 AM, xuelin.shi@freescale.com wrote: > From: Xuelin Shi > > the port number type should be consistent with librte_cmdline, > else there is potential endian issue. > > Signed-off-by: Xuelin Shi > --- > v2 change: > change port type to uint8 > rephrase patch title > > app/test-pmd/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 590e427..d5f31f2 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -5584,7 +5584,7 @@ cmdline_parse_token_string_t cmd_showport_what = > TOKEN_STRING_INITIALIZER(struct cmd_showport_result, what, > "info#stats#xstats#fdir#stat_qmap"); > cmdline_parse_token_num_t cmd_showport_portnum = > - TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, INT32); > + TOKEN_NUM_INITIALIZER(struct cmd_showport_result, portnum, UINT8); > > cmdline_parse_inst_t cmd_showport = { > .f = cmd_showport_parsed, > Acked-by: Olivier Matz