From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mzhao@luminatewireless.com>
Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com
 [209.85.220.45]) by dpdk.org (Postfix) with ESMTP id BAF6E234
 for <dev@dpdk.org>; Sat,  7 Feb 2015 08:24:18 +0100 (CET)
Received: by mail-pa0-f45.google.com with SMTP id et14so22067666pad.4
 for <dev@dpdk.org>; Fri, 06 Feb 2015 23:24:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:content-type:content-transfer-encoding;
 bh=urKVTOZ7y08/IjLToPSY54o5NJhWKMQF/6rVf8kA+Q0=;
 b=b+BnYJbYjaG1fSVph75w28K4MB80nXCpF+HXd2rMq7oZt6m/Muh3N/BF2dVnEwh/uF
 nI19uReE3mFc4lIy2MbFUdo29Alb8NAEIWeEr6RqYt+ZXIOAmCm3cgOP0SeNgZiiC5i/
 Tt347xFnY9hEibb/4+HgcC1VCWhuWT1is2FYuElAkstYBl0+4qQVABLrpkET6MzFEkMf
 gyqD5v/UNVz2m/ajkxTTWWZM0s1qPQYlWolj9nB7hhrsDgsQ4sKhLUVH4JyJ9uOtiKQ6
 OqZAhboVYQG3/nvZTAg1GEOK3pno2aVGqbcHRmeWyBQ+Z8WKgvcNMfWMnGeZ9wDRdWPi
 C4LA==
X-Gm-Message-State: ALoCoQlwaokkszLQRIk6YseVMEZ9RIOjePo86eV20x7EDtizXSeKHA5ysnXhViyVOXd1ir9WBbe8
X-Received: by 10.67.24.69 with SMTP id ig5mr11661652pad.17.1423293857142;
 Fri, 06 Feb 2015 23:24:17 -0800 (PST)
Received: from [192.168.1.192] ([50.174.17.220])
 by mx.google.com with ESMTPSA id wa3sm7822004pac.15.2015.02.06.23.24.16
 for <dev@dpdk.org>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 06 Feb 2015 23:24:16 -0800 (PST)
Message-ID: <54D5BD9F.7000902@luminatewireless.com>
Date: Fri, 06 Feb 2015 23:24:15 -0800
From: Ming Zhao <mzhao@luminatewireless.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: dev@dpdk.org
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] "virtual" C++ keyword used in rte_devargs.h and causes
 compilation error in C++
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Feb 2015 07:24:19 -0000

The code is in rte_devargs.h:

rte_devargs.h:

                /** Used if type is RTE_DEVTYPE_VIRTUAL. */
                struct {
                        /** Driver name. */
                        char drv_name[32];
                } virtual;
        };

Which caused clang compiler to report error when this file is included
by a cpp file, the error message is:

In file included from net/dpdk/testing/base-test.cc:3:
In file included from net/dpdk/testing/base-test.h:8:
third-party/dpdk/lib/librte_eal/common/include/rte_devargs.h:89:5:
error: 'virtual' can only appear on non-static
      member functions
                } virtual;
                  ^

I think we should try to pick another name for this field. I would
suggest calling it "vdev" instead, or I'll be happy to take another name
if someone comes with a different idea.

Thanks!
Ming