From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 230EE5A6B for ; Sun, 8 Feb 2015 21:01:25 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YKY6L-0005Q3-8t; Sun, 08 Feb 2015 21:05:12 +0100 Message-ID: <54D7C088.9080401@6wind.com> Date: Sun, 08 Feb 2015 21:01:12 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Cunming Liang , dev@dpdk.org References: <1422491072-5114-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-13-git-send-email-cunming.liang@intel.com> In-Reply-To: <1422842559-13617-13-git-send-email-cunming.liang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Feb 2015 20:01:25 -0000 Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For those none EAL thread, *_lcore_id* shall always be LCORE_ID_ANY. > The libraries using *_lcore_id* as index need to take care. > *_socket_id* always be SOCKET_ID_ANY unitl the thread changes the affinity unitl -> until > by rte_thread_set_affinity() > > Signed-off-by: Cunming Liang > --- > lib/librte_eal/bsdapp/eal/eal_thread.c | 4 ++-- > lib/librte_eal/linuxapp/eal/eal_thread.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_thread.c b/lib/librte_eal/bsdapp/eal/eal_thread.c > index 5b16302..2b3c9a8 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_thread.c > +++ b/lib/librte_eal/bsdapp/eal/eal_thread.c > @@ -56,8 +56,8 @@ > #include "eal_private.h" > #include "eal_thread.h" > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id); > -RTE_DEFINE_PER_LCORE(unsigned, _socket_id); > +RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = (unsigned)LCORE_ID_ANY; > +RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY; > RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset); > > /* > diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c > index 6eb1525..ab94e20 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_thread.c > +++ b/lib/librte_eal/linuxapp/eal/eal_thread.c > @@ -57,8 +57,8 @@ > #include "eal_private.h" > #include "eal_thread.h" > > -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id); > -RTE_DEFINE_PER_LCORE(unsigned, _socket_id); > +RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = (unsigned)LCORE_ID_ANY; > +RTE_DEFINE_PER_LCORE(unsigned, _socket_id) = (unsigned)SOCKET_ID_ANY; > RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset); As far as I understand, now a rte_lcore_id() can return LCORE_ID_ANY. This should be modified in the rte_lcore_id() API comments. Same for rte_socket_id(). I also wonder if the API of these functions should be modified to return an int instead of an unsigned as LCORE_ID_ANY is -1. Regards, Olivier