From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id EAF9E58E8 for ; Tue, 10 Feb 2015 02:30:45 +0100 (CET) Received: by mail-pa0-f50.google.com with SMTP id hz1so8770351pad.9 for ; Mon, 09 Feb 2015 17:30:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=PyICnpG9hxzlcBNDL2uhvLZ5qEmH4h/C9XOc6JIp2Nk=; b=aQqPFvay2ircTl2oiuY/1FDmqiQg98tG/JNlfvCFzgklG5ziFRvyZgLGaVMkV+I+YW ZqznHsURKW/KmbxYfJ89zhcC9FWFPJlE3UpnJQX2FEL7kfCxgJp3QdTwl2DngXIRle4J 8TSeXssMhPDOphsWETqOnFp1Kby0CzxhebM3BryIO72CsPYfsujHbdMiIwnJQ9ArytGt javgRAJjqsBoadFGNl1VXuYdTsOy/BvLw/hZRfcpn2uI2byPrIEKqgAJZhQEh/w5ED86 5y/GTKFua0KWGeGypiGC4bPwzFOMOsZw4rSiCaweUkP0phMyony1HZ/ishyNVywtEJ2q pfXQ== X-Gm-Message-State: ALoCoQlHoxAo6D4a9/tlKzQYiQd5gSlmJbSAvOHgkIk1m/vTrntUQi182pOnaiw2fAQPKke0ojT1 X-Received: by 10.66.146.39 with SMTP id sz7mr1074827pab.59.1423531845225; Mon, 09 Feb 2015 17:30:45 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id c2sm17515431pbu.49.2015.02.09.17.30.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Feb 2015 17:30:44 -0800 (PST) Message-ID: <54D95F41.4030907@igel.co.jp> Date: Tue, 10 Feb 2015 10:30:41 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1422763322-13742-4-git-send-email-mukawa@igel.co.jp> <1423470639-15744-1-git-send-email-mukawa@igel.co.jp> <1423470639-15744-8-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049DF12D@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C2049DF12D@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v7 07/14] ethdev: Add functions that will be used by port hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 01:30:46 -0000 On 2015/02/10 0:34, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >> Sent: Monday, February 9, 2015 8:31 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard; Qiu, Michael; Tetsuya Mukawa >> Subject: [PATCH v7 07/14] ethdev: Add functions that will be used by p= ort hotplug functions >> >> The patch adds following functions. >> >> - rte_eth_dev_save() >> The function is used for saving current rte_eth_dev structures. >> - rte_eth_dev_get_changed_port() >> The function receives the rte_eth_dev structures, then compare >> these with current values to know which port is actually >> attached or detached. >> - rte_eth_dev_get_addr_by_port() >> The function returns a pci address of an ethdev specified by port >> identifier. >> - rte_eth_dev_get_port_by_addr() >> The function returns a port identifier of an ethdev specified by >> pci address. >> - rte_eth_dev_get_name_by_port() >> The function returns a unique identifier name of an ethdev >> specified by port identifier. >> - Add rte_eth_dev_check_detachable() >> The function returns whether a PMD supports detach function. >> >> Also, the patch changes scope of rte_eth_dev_allocated() to global. >> This function will be called by virtual PMDs to support port hotplug. >> So change scope of the function to global. >> >> v7: >> - Add pt_driver checking to rte_eth_dev_check_detachable(). >> (Thanks to Qiu, Michael) >> v5: >> - Fix return value of below functions. >> rte_eth_dev_get_changed_port(). >> rte_eth_dev_get_port_by_addr(). >> v4: >> - Add parameter checking. >> v3: >> - Fix if-condition bug while comparing pci addresses. >> - Add error checking codes. >> Reported-by: Mark Enright >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_ether/rte_ethdev.c | 109 +++++++++++++++++++++++++++++++++= ++++++++- >> lib/librte_ether/rte_ethdev.h | 80 +++++++++++++++++++++++++++++++ >> 2 files changed, 188 insertions(+), 1 deletion(-) >> >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethd= ev.c index 7bed901..14a040a >> 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librte_ether/rte_ethdev.c >> @@ -206,7 +206,7 @@ rte_eth_dev_data_alloc(void) >> RTE_MAX_ETHPORTS * sizeof(*rte_eth_dev_data)); } >> >> -static struct rte_eth_dev * >> +struct rte_eth_dev * >> rte_eth_dev_allocated(const char *name) { >> unsigned i; >> @@ -426,6 +426,113 @@ rte_eth_dev_count(void) >> return (nb_ports); >> } >> >> +void >> +rte_eth_dev_save(struct rte_eth_dev *devs) { >> + if (devs =3D=3D NULL) >> + return; >> + > Hi Tetsuya, > > This function should probably have an input parameter for the size of t= he devs buffer. > This input parameter should be used with the memcpy function to ensure = that nothing is overwritten. Hi Bernard, I am sorry that I forgot to fix issues your suggested. (I checked the patchwork to submit v7 patches, and I forgot that cover letter wasn't involved in. So all suggestion to cover letter were not involved in v7 patches. I am sorry for that.) I will fix your all suggestions and submit again by this weekend. Regards, Tetsuya > Regards, > > Bernard. > >> + /* save current rte_eth_devices */ >> + memcpy(devs, rte_eth_devices, >> + sizeof(struct rte_eth_dev) * RTE_MAX_ETHPORTS); } >> + >> +int >> +rte_eth_dev_get_changed_port(struct rte_eth_dev *devs, uint8_t >> +*port_id) { >> + if ((devs =3D=3D NULL) || (port_id =3D=3D NULL)) >> + return -EINVAL; >> + >> + /* check which port was attached or detached */ >> + for (*port_id =3D 0; *port_id < RTE_MAX_ETHPORTS; (*port_id)++, devs= ++) { >> + if (rte_eth_devices[*port_id].attached ^ devs->attached) >> + return 0; >> + } >> + return -ENODEV; >> +} >> + >> +int >> +rte_eth_dev_get_addr_by_port(uint8_t port_id, struct rte_pci_addr >> +*addr) { >> + if (rte_eth_dev_validate_port(port_id, TRACE) =3D=3D DEV_INVALID) >> + return -EINVAL; >> + >> + if (addr =3D=3D NULL) { >> + PMD_DEBUG_TRACE("Null pointer is specified\n"); >> + return -EINVAL; >> + } >> + >> + *addr =3D rte_eth_devices[port_id].pci_dev->addr; >> + return 0; >> +} >> + >> +int >> +rte_eth_dev_get_port_by_addr(struct rte_pci_addr *addr, uint8_t >> +*port_id) { >> + struct rte_pci_addr *tmp; >> + >> + if ((addr =3D=3D NULL) || (port_id =3D=3D NULL)) { >> + PMD_DEBUG_TRACE("Null pointer is specified\n"); >> + return -EINVAL; >> + } >> + >> + for (*port_id =3D 0; *port_id < RTE_MAX_ETHPORTS; (*port_id)++) { >> + if (!rte_eth_devices[*port_id].attached) >> + continue; >> + if (!rte_eth_devices[*port_id].pci_dev) >> + continue; >> + tmp =3D &rte_eth_devices[*port_id].pci_dev->addr; >> + if (eal_compare_pci_addr(tmp, addr) =3D=3D 0) >> + return 0; >> + } >> + return -ENODEV; >> +} >> + >> +int >> +rte_eth_dev_get_name_by_port(uint8_t port_id, char *name) { >> + char *tmp; >> + >> + if (rte_eth_dev_validate_port(port_id, TRACE) =3D=3D DEV_INVALID) >> + return -EINVAL; >> + >> + if (name =3D=3D NULL) { >> + PMD_DEBUG_TRACE("Null pointer is specified\n"); >> + return -EINVAL; >> + } >> + >> + /* shouldn't check 'rte_eth_devices[i].data', >> + * because it might be overwritten by VDEV PMD */ >> + tmp =3D rte_eth_dev_data[port_id].name; >> + strncpy(name, tmp, strlen(tmp) + 1); >> + return 0; >> +} >> + >> +int >> +rte_eth_dev_check_detachable(uint8_t port_id) { >> + uint32_t drv_flags; >> + >> + if (port_id >=3D RTE_MAX_ETHPORTS) { >> + PMD_DEBUG_TRACE("Invalid port_id=3D%d\n", port_id); >> + return -EINVAL; >> + } >> + >> + if (rte_eth_devices[port_id].dev_type =3D=3D RTE_ETH_DEV_PHYSICAL) {= >> + switch (rte_eth_devices[port_id].pci_dev->pt_driver) { >> + case RTE_PT_IGB_UIO: >> + case RTE_PT_UIO_GENERIC: >> + break; >> + case RTE_PT_VFIO: >> + default: >> + return -ENOTSUP; >> + } >> + } >> + >> + drv_flags =3D rte_eth_devices[port_id].driver->pci_drv.drv_flags; >> + return !(drv_flags & RTE_PCI_DRV_DETACHABLE); } >> + >> static int >> rte_eth_dev_rx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queu= es) { diff --git >> a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index = 91d9e86..9919968 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -1616,6 +1616,86 @@ extern struct rte_eth_dev rte_eth_devices[]; e= xtern uint8_t >> rte_eth_dev_count(void); >> >> /** >> + * Function for internal use by port hotplug functions. >> + * Copies current ethdev structures to the specified pointer. >> + * >> + * @param devs The pointer to the ethdev structures >> + */ >> +extern void rte_eth_dev_save(struct rte_eth_dev *devs); >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Compare the specified ethdev structures with currents. Then >> + * if there is a port which status is changed, fill the specified >> +pointer >> + * with the port id of that port. >> + * @param devs The pointer to the ethdev structures >> + * @param port_id The pointer to the port id >> + * @return >> + * - 0 on success, negative on error >> + */ >> +extern int rte_eth_dev_get_changed_port( >> + struct rte_eth_dev *devs, uint8_t *port_id); >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Returns a pci address of a ethdev specified by port identifier. >> + * @param port_id >> + * The port identifier of the Ethernet device >> + * @param addr >> + * The pointer to the pci address >> + * @return >> + * - 0 on success, negative on error >> + */ >> +extern int rte_eth_dev_get_addr_by_port( >> + uint8_t port_id, struct rte_pci_addr *addr); >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Returns a port identifier of a ethdev specified by pci address. >> + * @param addr >> + * The pointer to the pci address of the Ethernet device. >> + * @param port_id >> + * The pointer to the port identifier >> + * @return >> + * - 0 on success, negative on error >> + */ >> +extern int rte_eth_dev_get_port_by_addr( >> + struct rte_pci_addr *addr, uint8_t *port_id); >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Returns a unique identifier name of a ethdev specified by port ide= ntifier. >> + * @param port_id >> + * The port identifier. >> + * @param name >> + * The pointer to the Unique identifier name for each Ethernet devic= e >> + * @return >> + * - 0 on success, negative on error >> + */ >> +extern int rte_eth_dev_get_name_by_port(uint8_t port_id, char *name);= >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Check whether or not, a PMD that is handling the ethdev specified = by >> +port >> + * identifier can support detach function. >> + * @param port_id >> + * The port identifier >> + * @return >> + * - 0 on supporting detach function, negative on not supporting >> + */ >> +extern int rte_eth_dev_check_detachable(uint8_t port_id); >> + >> +/** >> + * Function for internal use by port hotplug functions. >> + * Returns a ethdev slot specified by the unique identifier name. >> + * @param name >> + * The pointer to the Unique identifier name for each Ethernet devic= e >> + * @return >> + * - The pointer to the ethdev slot, on success. NULL on error >> + */ >> +extern struct rte_eth_dev *rte_eth_dev_allocated(const char *name); >> + >> +/** >> * Function for internal use by dummy drivers primarily, e.g. ring-ba= sed >> * driver. >> * Allocates a new ethdev slot for an ethernet device and returns the= pointer >> -- >> 1.9.1