From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id BC2E45949 for ; Tue, 10 Feb 2015 19:06:28 +0100 (CET) Received: from [172.16.251.227] (unknown [172.16.251.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.bisdn.de (Postfix) with ESMTPSA id 43495A34E0; Tue, 10 Feb 2015 19:06:28 +0100 (CET) Message-ID: <54DA48A2.9040706@bisdn.de> Date: Tue, 10 Feb 2015 19:06:26 +0100 From: Marc Sune User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Bruce Richardson References: <1415358037-424-1-git-send-email-marc.sune@bisdn.de> <54D9F2A1.2040102@bisdn.de> <20150210120230.GC18684@bricha3-MOBL3> <54D9F7E3.2060504@bisdn.de> <20150210132220.GD18684@bricha3-MOBL3> In-Reply-To: <20150210132220.GD18684@bricha3-MOBL3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Adding RTE_KNI_PREEMPT configuration option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 18:06:29 -0000 On 10/02/15 14:22, Bruce Richardson wrote: > On Tue, Feb 10, 2015 at 01:21:55PM +0100, Marc Sune wrote: >> On 10/02/15 13:02, Bruce Richardson wrote: >>> On Tue, Feb 10, 2015 at 12:59:29PM +0100, Marc Sune wrote: >>>> This patch of Nov 2014 hasn't been yet ACKed/NACKed. Could someone please >>>> give some quick feedback? >>>> >>>> Thanks >>>> marc >>>> >>> Idea is good, any chance it could be added as a run-time rather than >>> compile-time option? >> It is also an option. I wasn't really thinking someone would want to change >> this behaviour at runtime. If we think it is worth, I can have a closer look >> on it. Any other opinions on this? >> >> If we would go for a runtime flag, we would either have to add a config >> parameter to rte_kni_init() or add a specific call to turn on/off this knob, >> depending on whether it is sufficient to change this behaviour at >> bootstrapping time, or we want to also change it during 'operation'. In >> either case we would require some communication, probably via ioctl(), from >> user-space to kernel space. >> >> Thanks >> Marc >> > Yes, I can't see it needing to be changed much at runtime, however, we may need > to take account of those who are using precompiled DPDK libs. For those using > prebuilt DPDK libs, they won't have any ability to modify compile-time values. I see the point. So it should be enough to improve rte_kni_init() with an extra argument, but this means add some additional ioctl() calls, as far as I see. > > However, that being said, I have no particular objection to taking this change > in as-is for now. It only adds something, rather than taking it away. Yes, we can improve it in the future, I have no time right now. Thanks marc > > Regards, > /Bruce > >