From: Panu Matilainen <pmatilai@redhat.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config
Date: Wed, 11 Feb 2015 13:25:41 +0200 [thread overview]
Message-ID: <54DB3C35.9000104@redhat.com> (raw)
In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004F4AB6C@IRSMSX108.ger.corp.intel.com>
On 02/11/2015 12:51 PM, Gonzalez Monroy, Sergio wrote:
> Hi Panu,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
>> Sent: Wednesday, February 11, 2015 8:53 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared,
>> non-combined config
>>
>> When building shared, non-combined library, librte_vhost does not get
>> linked in, causing among other things vhost example to fail building to do
>> undefined symbols on linkage.
>>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>> ---
>> mk/rte.app.mk | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 95dbb0b..55d989e 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -125,6 +125,10 @@ LDLIBS += -lm
>> LDLIBS += -lrt
>> endif
>>
>> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)
>> +LDLIBS += -lrte_vhost
>> +endif
>> +
>> endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
>>
>> ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
>> --
>> 2.1.0
>
> I think that vhost is being linked in the wrong place (plugins section).
> The plugins only get linked when building static libraries.
> I think the patch should also remove vhost from the plugins section.
Right, so vhost isn't a pluggable driver in the sense that pmds are. I
wont claim to be familiar with all this virt-related puzzle pieces :)
I'll send an updated patch, I was just looking to fix build in my
particular config and ignored the rest.
On a related note, shouldn't librte_pmd_bond and librte_pmd_xenvirt be
included in the plugins section along with all the other pmds?
- Panu -
next prev parent reply other threads:[~2015-02-11 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 8:53 Panu Matilainen
2015-02-11 10:51 ` Gonzalez Monroy, Sergio
2015-02-11 11:25 ` Panu Matilainen [this message]
2015-02-11 12:31 ` Gonzalez Monroy, Sergio
2015-02-12 15:44 ` Thomas Monjalon
2015-02-13 7:27 ` Panu Matilainen
2015-02-13 9:28 ` Thomas Monjalon
2015-02-13 10:33 ` Panu Matilainen
2015-02-13 10:53 ` Thomas Monjalon
2015-02-13 13:18 ` Thomas Monjalon
2015-02-16 10:01 ` Panu Matilainen
2015-02-16 11:17 ` Thomas Monjalon
2015-02-16 11:58 ` Panu Matilainen
2015-02-11 13:43 ` [dpdk-dev] [PATCH v2] mk: fix librte_vhost linking Panu Matilainen
2015-02-11 13:47 ` Gonzalez Monroy, Sergio
2015-02-12 16:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB3C35.9000104@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).