From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DEF71AD99 for ; Thu, 12 Feb 2015 13:02:21 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CC2LjW032457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Feb 2015 07:02:21 -0500 Received: from localhost.localdomain (vpn1-5-97.ams2.redhat.com [10.36.5.97]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CC2JHH002336; Thu, 12 Feb 2015 07:02:20 -0500 Message-ID: <54DC964B.3050709@redhat.com> Date: Thu, 12 Feb 2015 14:02:19 +0200 From: Panu Matilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Bruce Richardson References: <09445d1715453b2eff4399da998717b967b829b3.1423739602.git.pmatilai@redhat.com> <20150212112518.GB10216@bricha3-MOBL3> In-Reply-To: <20150212112518.GB10216@bricha3-MOBL3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Make -Werror optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Feb 2015 12:02:22 -0000 On 02/12/2015 01:25 PM, Bruce Richardson wrote: > On Thu, Feb 12, 2015 at 01:13:22PM +0200, Panu Matilainen wrote: >> This adds new CONFIG_RTE_ERROR_ON_WARNING config option to enable >> fail-on-warning compile behavior, defaulting to off. >> >> Failing build on warnings is a useful developer tool but its bad >> for release tarballs which can and do get built with newer >> compilers than what was used/available during development. Compilers >> routinely add new warnings so code which built silently with cc X >> might no longer do so with X+1. This doesn't make the existing code >> any more buggier and failing the build in this case does not help >> not help improve code quality of an already released version either. > > This can already be achieve by passing EXTRA_CFLAGS='-Wno-error' into the > build command. I don't like changing the default option here. Better to > instead document how to disable the warning flags if necessary. Well, optimally it would only default to off in released versions, which is where the Werror behavior is just annoying without being useful. For a practical example of how silly this can be: just got a build failure with 1.8 due to "variable set but not used" warnings, because gcc 5 is "smarter" and finds couple of cases older versions did not. So everybody using gcc 5 to build the just-released 1.8 will be required to hunt down and pass in that extra disabler, for no good reason. - Panu -