* [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
@ 2015-02-11 13:30 Sergio Gonzalez Monroy
2015-02-12 15:12 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Sergio Gonzalez Monroy @ 2015-02-11 13:30 UTC (permalink / raw)
To: dev
Common rte_eal_iopl_init function is missing from eal version map.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index d36286e..a5ca65a 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -32,6 +32,7 @@ DPDK_2.0 {
rte_eal_get_physmem_size;
rte_eal_has_hugepages;
rte_eal_hpet_init;
+ rte_eal_iopl_init;
rte_eal_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index d36286e..a5ca65a 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -32,6 +32,7 @@ DPDK_2.0 {
rte_eal_get_physmem_size;
rte_eal_has_hugepages;
rte_eal_hpet_init;
+ rte_eal_iopl_init;
rte_eal_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
2015-02-11 13:30 [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map Sergio Gonzalez Monroy
@ 2015-02-12 15:12 ` Thomas Monjalon
2015-02-12 15:18 ` Gonzalez Monroy, Sergio
2015-02-12 15:39 ` Sergio Gonzalez Monroy
2015-02-12 15:40 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2 siblings, 1 reply; 9+ messages in thread
From: Thomas Monjalon @ 2015-02-12 15:12 UTC (permalink / raw)
To: Sergio Gonzalez Monroy; +Cc: dev
2015-02-11 13:30, Sergio Gonzalez Monroy:
> Common rte_eal_iopl_init function is missing from eal version map.
How did you see it?
Thanks
> rte_eal_hpet_init;
> + rte_eal_iopl_init;
> rte_eal_init;
You missed the alphabetical order, you were not so far ;)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
2015-02-12 15:12 ` Thomas Monjalon
@ 2015-02-12 15:18 ` Gonzalez Monroy, Sergio
2015-02-12 15:28 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Gonzalez Monroy, Sergio @ 2015-02-12 15:18 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
On 12/02/2015 15:12, Thomas Monjalon wrote:
> 2015-02-11 13:30, Sergio Gonzalez Monroy:
>> Common rte_eal_iopl_init function is missing from eal version map.
> How did you see it?
> Thanks
Building shared libraries and using virtio PMD would result in undefined
reference symbol.
Should I add it to the commit log?
>> rte_eal_hpet_init;
>> + rte_eal_iopl_init;
>> rte_eal_init;
> You missed the alphabetical order, you were not so far ;)
Oh, I did not realize it was alphabetical order, I'll send v2.
Regards,
Sergio
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
2015-02-12 15:18 ` Gonzalez Monroy, Sergio
@ 2015-02-12 15:28 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2015-02-12 15:28 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio; +Cc: dev
2015-02-12 15:18, Gonzalez Monroy, Sergio:
> On 12/02/2015 15:12, Thomas Monjalon wrote:
> > 2015-02-11 13:30, Sergio Gonzalez Monroy:
> >> Common rte_eal_iopl_init function is missing from eal version map.
> > How did you see it?
> > Thanks
> Building shared libraries and using virtio PMD would result in undefined
> reference symbol.
> Should I add it to the commit log?
Yes please.
> >> rte_eal_hpet_init;
> >> + rte_eal_iopl_init;
> >> rte_eal_init;
> > You missed the alphabetical order, you were not so far ;)
> Oh, I did not realize it was alphabetical order, I'll send v2.
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
2015-02-11 13:30 [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map Sergio Gonzalez Monroy
2015-02-12 15:12 ` Thomas Monjalon
@ 2015-02-12 15:39 ` Sergio Gonzalez Monroy
2015-02-12 15:43 ` Gonzalez Monroy, Sergio
2015-02-12 15:40 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2 siblings, 1 reply; 9+ messages in thread
From: Sergio Gonzalez Monroy @ 2015-02-12 15:39 UTC (permalink / raw)
To: dev
Building shared libraries and using virtio PMD results in undefined
reference to 'rte_eal_iopl_init'.
Add missing function to eal version map.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index d36286e..5ed6e4d 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -33,6 +33,7 @@ DPDK_2.0 {
rte_eal_has_hugepages;
rte_eal_hpet_init;
rte_eal_init;
+ rte_eal_iopl_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
rte_eal_mp_wait_lcore;
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index d36286e..5ed6e4d 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -33,6 +33,7 @@ DPDK_2.0 {
rte_eal_has_hugepages;
rte_eal_hpet_init;
rte_eal_init;
+ rte_eal_iopl_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
rte_eal_mp_wait_lcore;
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map
2015-02-12 15:39 ` Sergio Gonzalez Monroy
@ 2015-02-12 15:43 ` Gonzalez Monroy, Sergio
0 siblings, 0 replies; 9+ messages in thread
From: Gonzalez Monroy, Sergio @ 2015-02-12 15:43 UTC (permalink / raw)
To: dev
On 12/02/2015 15:39, Sergio Gonzalez Monroy wrote:
> Building shared libraries and using virtio PMD results in undefined
> reference to 'rte_eal_iopl_init'.
>
> Add missing function to eal version map.
>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
> lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
> lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
> 2 files changed, 2 insertions(+)
>
Self-NACK missing v2 details.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map
2015-02-11 13:30 [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map Sergio Gonzalez Monroy
2015-02-12 15:12 ` Thomas Monjalon
2015-02-12 15:39 ` Sergio Gonzalez Monroy
@ 2015-02-12 15:40 ` Sergio Gonzalez Monroy
2015-02-19 11:38 ` De Lara Guarch, Pablo
2 siblings, 1 reply; 9+ messages in thread
From: Sergio Gonzalez Monroy @ 2015-02-12 15:40 UTC (permalink / raw)
To: dev
Building shared libraries and using virtio PMD results in undefined
reference to 'rte_eal_iopl_init'.
Add missing function to eal version map.
Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
---
v2:
- more detailed commit
- add entry in alphabetical order
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index d36286e..5ed6e4d 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -33,6 +33,7 @@ DPDK_2.0 {
rte_eal_has_hugepages;
rte_eal_hpet_init;
rte_eal_init;
+ rte_eal_iopl_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
rte_eal_mp_wait_lcore;
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index d36286e..5ed6e4d 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -33,6 +33,7 @@ DPDK_2.0 {
rte_eal_has_hugepages;
rte_eal_hpet_init;
rte_eal_init;
+ rte_eal_iopl_init;
rte_eal_lcore_role;
rte_eal_mp_remote_launch;
rte_eal_mp_wait_lcore;
--
1.9.3
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map
2015-02-12 15:40 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
@ 2015-02-19 11:38 ` De Lara Guarch, Pablo
2015-02-20 10:07 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: De Lara Guarch, Pablo @ 2015-02-19 11:38 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Thursday, February 12, 2015 3:41 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map
>
> Building shared libraries and using virtio PMD results in undefined
> reference to 'rte_eal_iopl_init'.
>
> Add missing function to eal version map.
>
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> ---
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2] eal: add rte_eal_iopl_init to version map
2015-02-19 11:38 ` De Lara Guarch, Pablo
@ 2015-02-20 10:07 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2015-02-20 10:07 UTC (permalink / raw)
To: Gonzalez Monroy, Sergio; +Cc: dev
> > Building shared libraries and using virtio PMD results in undefined
> > reference to 'rte_eal_iopl_init'.
> >
> > Add missing function to eal version map.
> >
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-02-20 10:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-11 13:30 [dpdk-dev] [PATCH] eal: add rte_eal_iopl_init to version map Sergio Gonzalez Monroy
2015-02-12 15:12 ` Thomas Monjalon
2015-02-12 15:18 ` Gonzalez Monroy, Sergio
2015-02-12 15:28 ` Thomas Monjalon
2015-02-12 15:39 ` Sergio Gonzalez Monroy
2015-02-12 15:43 ` Gonzalez Monroy, Sergio
2015-02-12 15:40 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2015-02-19 11:38 ` De Lara Guarch, Pablo
2015-02-20 10:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).