From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 1B6EEB41C for ; Fri, 13 Feb 2015 11:06:34 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YMDCR-0004XN-Mx; Fri, 13 Feb 2015 11:10:22 +0100 Message-ID: <54DDCC9C.8080809@6wind.com> Date: Fri, 13 Feb 2015 11:06:20 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Cunming Liang , dev@dpdk.org References: <1423728996-3004-1-git-send-email-cunming.liang@intel.com> <1423791501-1555-1-git-send-email-cunming.liang@intel.com> In-Reply-To: <1423791501-1555-1-git-send-email-cunming.liang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 00/19] support multi-pthread per core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 10:06:34 -0000 Hi, On 02/13/2015 02:38 AM, Cunming Liang wrote: > v6 changes: > rename RTE_RING_PAUSE_REP(_COUNT) and set default to 0 > rollback to use RTE_MAX_LCORE when checking valid lcore_id for EAL thread > > v5 changes: > reorder some patch and split into addtional two patches > rte_thread_get_affinity() return type change to avoid > add RTE_RING_PAUSE_REP into config and by default turn off > > v4 changes: > new patch fixing strnlen() invalid return in 32bit icc [03/17] > update and add more comments on sched_yield() [16/17] > > v3 changes: > new patch adding sched_yield() in rte_ring to avoid long spin [16/17] > > v2 changes: > add '-' support for EAL option '--lcores' [02/17] > > The patch series contain the enhancements of EAL and fixes for libraries > to run multi-pthreads(either EAL or non-EAL thread) per physical core. > Two major changes list as below: > - Extend the core affinity of each EAL thread to 1:n. > Each lcore stands for a EAL thread rather than a logical core. > The change adds new EAL option to allow static lcore to cpuset assginment. > Then a lcore(EAL thread) affinity to a cpuset, original 1:1 mapping is the special case. > - Fix the libraries to allow running on any non-EAL thread. > It fix the gaps running libraries in non-EAL thread(dynamic created by user). > Each fix libraries take care the case of rte_lcore_id() >= RTE_MAX_LCORE. > > Thanks a million for the comments from Konstantin, Bruce, Mirek and Stephen in RFC review. > > Cunming Liang (19): > eal: add cpuset into per EAL thread lcore_config > eal: fix PAGE_SIZE redefine complaint on freebsd > eal: new eal option '--lcores' for cpu assignment > eal: fix wrong strnlen() return value in 32bit icc > eal: add support parsing socket_id from cpuset > eal: new TLS definition and API declaration > eal: add eal_common_thread.c for common thread API > eal: standardize init sequence between linux and bsd > eal: add rte_gettid() to acquire unique system tid > eal: apply affinity of EAL thread by assigned cpuset > enic: fix re-define freebsd compile complain > malloc: fix the issue of SOCKET_ID_ANY > log: fix the gap to support non-EAL thread > eal: set _lcore_id and _socket_id to (-1) by default > eal: fix recursive spinlock in non-EAL thraed > mempool: add support to non-EAL thread > ring: add support to non-EAL thread > ring: add sched_yield to avoid spin forever > timer: add support to non-EAL thread > > config/common_bsdapp | 1 + > config/common_linuxapp | 1 + > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/bsdapp/eal/eal.c | 14 +- > lib/librte_eal/bsdapp/eal/eal_lcore.c | 14 + > lib/librte_eal/bsdapp/eal/eal_memory.c | 8 +- > lib/librte_eal/bsdapp/eal/eal_thread.c | 77 ++---- > lib/librte_eal/common/eal_common_log.c | 17 +- > lib/librte_eal/common/eal_common_options.c | 308 ++++++++++++++++++++- > lib/librte_eal/common/eal_common_thread.c | 150 ++++++++++ > lib/librte_eal/common/eal_options.h | 2 + > lib/librte_eal/common/eal_thread.h | 47 ++++ > .../common/include/generic/rte_spinlock.h | 4 +- > lib/librte_eal/common/include/rte_eal.h | 27 ++ > lib/librte_eal/common/include/rte_lcore.h | 40 ++- > lib/librte_eal/common/include/rte_log.h | 5 + > lib/librte_eal/linuxapp/eal/Makefile | 4 + > lib/librte_eal/linuxapp/eal/eal.c | 8 +- > lib/librte_eal/linuxapp/eal/eal_lcore.c | 15 +- > lib/librte_eal/linuxapp/eal/eal_thread.c | 77 ++---- > lib/librte_malloc/malloc_heap.h | 7 +- > lib/librte_mempool/rte_mempool.h | 18 +- > lib/librte_pmd_enic/enic.h | 4 +- > lib/librte_pmd_enic/enic_compat.h | 2 +- > lib/librte_pmd_enic/vnic/vnic_dev.c | 6 +- > lib/librte_ring/rte_ring.h | 41 ++- > lib/librte_timer/rte_timer.c | 32 ++- > lib/librte_timer/rte_timer.h | 4 +- > 28 files changed, 765 insertions(+), 169 deletions(-) > create mode 100644 lib/librte_eal/common/eal_common_thread.c > Series: Acked-by: Olivier Matz Maybe a doc update will be required, could you have a look at it? Another question, is it planned to add some unit tests for this feature? Thanks!