From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 280AEB5AC for ; Mon, 16 Feb 2015 09:15:44 +0100 (CET) Received: by mail-pa0-f53.google.com with SMTP id lf10so33524581pab.12 for ; Mon, 16 Feb 2015 00:15:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ru9Dj95LRk3Wdx2eNyb28NJilPwwe7h/6eLjHwCqbcA=; b=X1QwFUyNJuW/e1bs/NlAa8Bk1xN50g10+iMiNKsUNhl1d/zHF5TeLGwIhAeFgZjM0l azgzqb6U+Pkz59YAeZstEt/JwAGhKOIDTK0qgWGKzZC8P60l185CRNmNiLd0Emf0wuFA EFgu92i+q5+tAb9cDxa79bFpMSpqbF/N/2cg+kS8Aiua2TYJy1iCdOw1NZ44tZZgohpA dZh0/P+3fIBIKfbWqu6umQykxOughrnkHOgBeDGPEUp/PweUBxzHYLuA5c0UXqoYUpJD pGq3SIJVGnaqdBcwUo3LT35TSpbJ0gnUWkYqVMRJxkPK4FHErf8aPLV2Vbdthrmmwc+w 3cVw== X-Gm-Message-State: ALoCoQl6j8PCLRB/nF5ZiE4awc3sfa7aJCWF2Nc9WGFCnMdZ9qaBaFwb26Y/cPanbhW6dKHJEuW5 X-Received: by 10.70.36.129 with SMTP id q1mr38185812pdj.6.1424074542356; Mon, 16 Feb 2015 00:15:42 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id em4sm13834857pbc.46.2015.02.16.00.15.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 00:15:41 -0800 (PST) Message-ID: <54E1A72B.1090601@igel.co.jp> Date: Mon, 16 Feb 2015 17:15:39 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Xie, Huawei" References: <1423717649-11818-1-git-send-email-huawei.xie@intel.com> <1423717649-11818-2-git-send-email-huawei.xie@intel.com> In-Reply-To: <1423717649-11818-2-git-send-email-huawei.xie@intel.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 01/11] lib/librte_vhost: enable VIRTIO_NET_F_CTRL_RX VIRTIO_NET_F_CTRL_RX is dependant on VIRTIO_NET_F_CTRL_VQ. Observed that virtio-net driver in guest would crash with only CTRL_RX enabled. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 08:15:44 -0000 Hi Xie, Could you please check commit title? I guess this commit title involves first sentence of commit log. Thanks, Tetsuya On 2015/02/12 14:07, Huawei Xie wrote: > In virtnet_send_command: > > /* Caller should know better */ > BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ) || > (out + in > VIRTNET_SEND_COMMAND_SG_MAX)); > > Signed-off-by: Huawei Xie > --- > lib/librte_vhost/virtio-net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > index b041849..52b4957 100644 > --- a/lib/librte_vhost/virtio-net.c > +++ b/lib/librte_vhost/virtio-net.c > @@ -73,7 +73,8 @@ static struct virtio_net_config_ll *ll_root; > > /* Features supported by this lib. */ > #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ > - (1ULL << VIRTIO_NET_F_CTRL_RX)) > + (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ > + (1ULL << VIRTIO_NET_F_CTRL_RX)) > static uint64_t VHOST_FEATURES = VHOST_SUPPORTED_FEATURES; > > /* Line size for reading maps file. */