From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 1C7BBB5E4
 for <dev@dpdk.org>; Mon, 16 Feb 2015 15:15:29 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1YNMW2-00077Y-6Z; Mon, 16 Feb 2015 15:19:18 +0100
Message-ID: <54E1FB75.8090404@6wind.com>
Date: Mon, 16 Feb 2015 15:15:17 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.3.0
MIME-Version: 1.0
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
References: <1423937607-35845-1-git-send-email-keith.wiles@intel.com>
In-Reply-To: <1423937607-35845-1-git-send-email-keith.wiles@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] Add Q variable to external builds to be quite
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 14:15:29 -0000

Hi Keith,

On 02/14/2015 07:13 PM, Keith Wiles wrote:
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  mk/rte.extvars.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
> index 3e5a990..83a5721 100644
> --- a/mk/rte.extvars.mk
> +++ b/mk/rte.extvars.mk
> @@ -66,6 +66,10 @@ endif
>  RTE_OUTPUT ?= $(RTE_SRCDIR)/build
>  export RTE_OUTPUT
>  
> +# define Q to '@' or not. $(Q) is used to prefix all shell commands to
> +# be executed silently.
> +Q=@
> +
>  # if we are building an external application, include SDK
>  # configuration and include project configuration if any
>  include $(RTE_SDK_BIN)/.config
> 

In the examples/ directory, rte.extvars.mk is never included directly.
They use rte.vars.mk, which already properly defines the $(Q) variable
(its value depends on V= argument).

So I think we don't need this patch.

Regards,
Olivier