* [dpdk-dev] [PATCH] Add Q variable to external builds to be quite
@ 2015-02-14 18:13 Keith Wiles
2015-02-16 14:15 ` Olivier MATZ
0 siblings, 1 reply; 2+ messages in thread
From: Keith Wiles @ 2015-02-14 18:13 UTC (permalink / raw)
To: dev
Signed-off-by: Keith Wiles <keith.wiles@intel.com>
---
mk/rte.extvars.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
index 3e5a990..83a5721 100644
--- a/mk/rte.extvars.mk
+++ b/mk/rte.extvars.mk
@@ -66,6 +66,10 @@ endif
RTE_OUTPUT ?= $(RTE_SRCDIR)/build
export RTE_OUTPUT
+# define Q to '@' or not. $(Q) is used to prefix all shell commands to
+# be executed silently.
+Q=@
+
# if we are building an external application, include SDK
# configuration and include project configuration if any
include $(RTE_SDK_BIN)/.config
--
2.3.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] Add Q variable to external builds to be quite
2015-02-14 18:13 [dpdk-dev] [PATCH] Add Q variable to external builds to be quite Keith Wiles
@ 2015-02-16 14:15 ` Olivier MATZ
0 siblings, 0 replies; 2+ messages in thread
From: Olivier MATZ @ 2015-02-16 14:15 UTC (permalink / raw)
To: Keith Wiles, dev
Hi Keith,
On 02/14/2015 07:13 PM, Keith Wiles wrote:
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> mk/rte.extvars.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
> index 3e5a990..83a5721 100644
> --- a/mk/rte.extvars.mk
> +++ b/mk/rte.extvars.mk
> @@ -66,6 +66,10 @@ endif
> RTE_OUTPUT ?= $(RTE_SRCDIR)/build
> export RTE_OUTPUT
>
> +# define Q to '@' or not. $(Q) is used to prefix all shell commands to
> +# be executed silently.
> +Q=@
> +
> # if we are building an external application, include SDK
> # configuration and include project configuration if any
> include $(RTE_SDK_BIN)/.config
>
In the examples/ directory, rte.extvars.mk is never included directly.
They use rte.vars.mk, which already properly defines the $(Q) variable
(its value depends on V= argument).
So I think we don't need this patch.
Regards,
Olivier
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-16 14:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-14 18:13 [dpdk-dev] [PATCH] Add Q variable to external builds to be quite Keith Wiles
2015-02-16 14:15 ` Olivier MATZ
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).