From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 6DCFCB5DA
 for <dev@dpdk.org>; Mon, 16 Feb 2015 15:18:45 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1YNMZE-00077g-Im; Mon, 16 Feb 2015 15:22:36 +0100
Message-ID: <54E1FC3B.5080700@6wind.com>
Date: Mon, 16 Feb 2015 15:18:35 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Icedove/31.3.0
MIME-Version: 1.0
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
References: <1423939927-37376-1-git-send-email-keith.wiles@intel.com>
In-Reply-To: <1423939927-37376-1-git-send-email-keith.wiles@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] Add support to read
 target/generic/rte.vars.mk file for external builds
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 14:18:46 -0000

Hi Keith,

On 02/14/2015 07:52 PM, Keith Wiles wrote:
> The external build of applications does not import the target/generic/rte.vars.mk
> file, which is needed for locating DPDK headers and libraries.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  mk/rte.extvars.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/mk/rte.extvars.mk b/mk/rte.extvars.mk
> index 49fc9f2..2811ff9 100644
> --- a/mk/rte.extvars.mk
> +++ b/mk/rte.extvars.mk
> @@ -82,3 +82,10 @@ RTE_MACHINE := $(CONFIG_RTE_MACHINE:"%"=%)
>  RTE_EXEC_ENV := $(CONFIG_RTE_EXEC_ENV:"%"=%)
>  RTE_TOOLCHAIN := $(CONFIG_RTE_TOOLCHAIN:"%"=%)
>  RTE_MK_EXT := $(CONFIG_RTE_MK_EXT:"%"=%)
> +
> +ifneq ($(wildcard $(RTE_SDK)/mk/target/$(RTE_TARGET)/rte.vars.mk),)
> +include $(RTE_SDK)/mk/target/$(RTE_TARGET)/rte.vars.mk
> +else
> +include $(RTE_SDK)/mk/target/generic/rte.vars.mk
> +endif
> +
> 

Same comment than for the other patch.
The external apps should include "rte.vars.mk" as in examples.