From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mukawa@igel.co.jp>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 52532B674
 for <dev@dpdk.org>; Tue, 17 Feb 2015 07:15:49 +0100 (CET)
Received: by paceu11 with SMTP id eu11so3930949pac.10
 for <dev@dpdk.org>; Mon, 16 Feb 2015 22:15:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=pEl49EbdT9lSTWBrV0lxO2NI49LmFQZvRNVh6t2SsRk=;
 b=CAeBSwmmX1L4bSKHMxo5awKbKfsJPBR30CW/cmy2zwjnNeoLeMhVvypfdhLVfa6xox
 s9X29mzOAVFMJZU/f32R58TqQUBemFCZQD262+HnA4cXxQ2G1spniQ/Ep1ctwE2VlBqB
 V4i1YLWrgeyeB6ZM3Yjt1Wx8fdtkHKTK7fX9XYef64aLyjGHGKxsURu6BEKMBd8Jvx5h
 muqEF32o/CvHnx8ch6fCASdzZEW5FfeY3xcOxv8qBa/yATLwD83u0FT5EnRgCpN66Rj/
 c+jSxdxiy1kKFB4Ksg4c7tYOVfFF4kGtCji6OlYfa6hlA8fR7JRadvW+UhuHLSr/nskL
 7PTA==
X-Gm-Message-State: ALoCoQmgTw6LEVphDRz25tKinKtl4x3JPXhy0Z8Z3in7Kdk/vGNowYBF7YR5RV2tCGtJQQkl6d8C
X-Received: by 10.68.136.201 with SMTP id qc9mr40263283pbb.144.1424153748780; 
 Mon, 16 Feb 2015 22:15:48 -0800 (PST)
Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132])
 by mx.google.com with ESMTPSA id o3sm16590842pdj.5.2015.02.16.22.15.47
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 16 Feb 2015 22:15:48 -0800 (PST)
Message-ID: <54E2DC92.4090408@igel.co.jp>
Date: Tue, 17 Feb 2015 15:15:46 +0900
From: Tetsuya Mukawa <mukawa@igel.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp>
 <1424060073-23484-1-git-send-email-mukawa@igel.co.jp>
 <1424060073-23484-12-git-send-email-mukawa@igel.co.jp>
 <1454524.7cdRN9bmFB@xps13>
In-Reply-To: <1454524.7cdRN9bmFB@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 11/14] ethdev: Add one dev_type parameter
 to rte_eth_dev_allocate
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Feb 2015 06:15:49 -0000

On 2015/02/17 10:24, Thomas Monjalon wrote:
> 2015-02-16 13:14, Tetsuya Mukawa:
>> This new parameter is needed to keep device type like physical or virt=
ual.
> Actually types are "PCI" and "virtual".

OK, I will change above sentence to explain it more clearly.

>> Port detaching processes are different between physical and virtual.
>> This parameter lets detaching function know a device type of the port.=

> I think the type should be guessed automatically thanks to register inf=
os.
>

It seems I forgot rewrite this comment, I will change it.