From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 18E65B5C7 for ; Wed, 18 Feb 2015 02:54:53 +0100 (CET) Received: by pdbnh10 with SMTP id nh10so43640402pdb.11 for ; Tue, 17 Feb 2015 17:54:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=PbOxF6LLqdovTMvD+8nJZvNEsO7olahOsFRFLKCZOZk=; b=ixHxR3OHHYlMMTaGF+V/IsOKC858Kc70JRO5s3NIDNZqsl0k3qVzpMEXiXphlPxZm3 XOSoWY68kKaLf/9lHnrZ4WqG70c8fPSlvcVlQbc/EwrlKjCoVP415nY6/HsoVcmZxnLt D0RaUbx5MzwnjM2cpuWgPsf63pL/U6IXAkH2TAHgDdFfXKiy6RKZjeaoWTZD9YLW+nwt gxtbPslFob9Blr9fGK4lHdGzFuBqtOPQfIYHxwnABEqOt+E6loWdiNIyANN3+adpI0BD 4TZryz/kixj+6x3ihJUxT1HCE/e/fcdamMoB/zlPxzqh1tMaXPLkYvQ5NN4A20xQFZyj BYRg== X-Gm-Message-State: ALoCoQlYfVTKNmqfY5GJQviMF1sXj47c6TgvkEqj+yDPAyOCFv6k2/n8r+Rk39q7uqyL0KgP9PGI X-Received: by 10.70.41.231 with SMTP id i7mr53360000pdl.102.1424224492402; Tue, 17 Feb 2015 17:54:52 -0800 (PST) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id lf13sm19133609pab.2.2015.02.17.17.54.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2015 17:54:51 -0800 (PST) Message-ID: <54E3F0E9.402@igel.co.jp> Date: Wed, 18 Feb 2015 10:54:49 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Maxime Leroy References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <1424060073-23484-1-git-send-email-mukawa@igel.co.jp> <1424060073-23484-13-git-send-email-mukawa@igel.co.jp> <83798909.brLNWNC9tj@xps13> <54E300F8.8000503@igel.co.jp> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 01:54:53 -0000 On 2015/02/18 1:15, Maxime Leroy wrote: > Hi Tetsuya, > > On Tue, Feb 17, 2015 at 9:51 AM, Tetsuya Mukawa wro= te: >> >>>> + /* get port_id enabled by above procedures */ >>>> + if (rte_eth_dev_get_changed_port(devs, &new_port_id)) >>>> + goto err2; >>> [...] >>> >>>> /** >>>> + * Uninitilization function called for each device driver once. >>>> + */ >>>> +typedef int (rte_dev_uninit_t)(const char *name, const char *args);= >>> Why do you need args for uninit? >>> >> I just added for the case that finalization code of PMD needs it. >> But, probably "args" parameter can be removed. >> >> > I think there are no needs to have any args in the uninit function: > 1) You librte_pmd_null doesn't use it > 2) You give exactly the same argument that was used by the init > function. A driver should have already stored these parameters in an > internal private structure at initialization. So it's not needed to > give me back for uninit method. > > From my understanding devargs_list is only needed at the init to store > the arguments when we parse the command line. Then, at initialization, > rte_eal_dev_init creates the devices from this list . > > By removing args from uninit function, you doesn't need to add and > remove anymore devargs in devargs_list to (de)attach a new device. > > What do you think ? Hi Maxime, Yes, I agree. We can remove the argument. I will do it. Regards, Tetsuya > > Maxime